Minor changes for cgroup and devices subsystem #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifupan
reviewed
Aug 1, 2023
lifupan
reviewed
Aug 1, 2023
The changes include: - Expose `create()` and add `exists()` for `Cgroup`: The changes are allowed to load cgroup and test if the cgroup exists. If not exists, performing the `create()` directly to avoid performing `new()`. - Make path of devices cgroup error more details: The origin path is either `devices.allow` or `devices.deny`. It not shows which cgroup it belongs to. Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
lifupan
approved these changes
Aug 1, 2023
Tim-Zhang
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes include:
create()and addexists()forCgroup: The changes are allowed to load cgroup and test if the cgroup exists. If not exists, performing thecreate()directly to avoid performingCgroup::new().devices.allowordevices.deny. It not shows which cgroup it belongs to.