Support setting max memory limit in cgroup v2 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting memory.max/memory.swap.max in cgroup v2, Linux uses "max" instead of "-1" to indicate no restriction on memory usage. The set_limit and set_memswap_limit functions of the memory controller accept i64 as a parameter. In cgroupv2, if the parameter is -1, "max" should be written into the cgroup file. Fixes kata-containers#128 Signed-off-by: mengze <mengze@linux.alibaba.com>
Tim-Zhang
approved these changes
Oct 23, 2023
liubin
approved these changes
Oct 23, 2023
Tim-Zhang
added a commit
to Tim-Zhang/cgroups-rs
that referenced
this pull request
Oct 25, 2023
To include kata-containers#126, kata-containers#127, kata-containers#129 Signed-off-by: Tim Zhang <tim@hyper.sh>
Merged
Tim-Zhang
added a commit
to Tim-Zhang/cgroups-rs
that referenced
this pull request
Oct 25, 2023
To include kata-containers#126, kata-containers#127, kata-containers#129 Signed-off-by: Tim Zhang <tim@hyper.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting memory.max/memory.swap.max in cgroup v2, Linux uses "max" instead of "-1" to indicate no restriction on memory usage. The set_limit and set_memswap_limit functions of the memory controller accept i64 as a parameter. In cgroupv2, if the parameter is -1, "max" should be written into the cgroup file.