Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

check if hardwarte is capable of running Kata Containers #139

Closed
wants to merge 2 commits into from
Closed

check if hardwarte is capable of running Kata Containers #139

wants to merge 2 commits into from

Conversation

newtonjose
Copy link

@newtonjose newtonjose commented Jun 5, 2018

docs: Add a section "Hardware requirements" on Ubuntu user guide.

Fixes #373.

Signed-off-by: Newton Jose <josephnewton001@gmail.com

Add this section on user guide because when I try integrate with K8s and have this issue: kata-containers/runtime#373
@chavafg
Copy link
Contributor

chavafg commented Jun 5, 2018

hi @n3wt0nSAN, thanks for your PR.

Can you rework your commit to match the patch-format required?
You can find information here:
https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#patch-format

@jodh-intel
Copy link
Contributor

Hi @n3wt0nSAN - thanks for raising. I think it's a good idea to provide such details, but to avoid duplication, please can you simply add a sentence referencing:

Since we want to keep the install docs as similar and brief as possible, please could you apply that same change to the CentOS and Fedora docs too:

@newtonjose
Copy link
Author

Thanks for the posts. I hope to contribute more often. :)

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
removes some duplication and references a place with a touch more info.

@grahamwhaley
Copy link
Contributor

oh, and...

  • typo in the PR - s/hardwarte/hardware/
  • CI failed as you don't meet the commit message style requirements - here is the output from the logs:
Found 2 commits between commit HEAD and branch master
ERROR: Commit 1b121734d24b6ae41243391e8e9ed5f25a311034: Failed to find subsystem in subject: "check if hardwarte is capable of running Kata Containers"
ERROR: checkcommits failed. See the document below for help on formatting
commits for the project.

See the link that chavafg provided earlier.

@newtonjose
Copy link
Author

this is my be the accentuation. I change.

@newtonjose newtonjose closed this Jun 11, 2018
devimc pushed a commit to devimc/kata-documentation that referenced this pull request Sep 2, 2019
Fixes: kata-containers#139

Signed-off-by: Nitesh Konkar <niteshkonkar@in.ibm.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants