-
Notifications
You must be signed in to change notification settings - Fork 304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @raravena80 - Thanks for raising - this is going to be a really useful resource!
I've added a few comments mostly around consistency with our existing docs.
Also, Travis is failing since our checkcommits
tool is complaining there is no "Fixes #XXX
" comment in you commit, and pointing you to:
I've raised #273 for you so can amend your commit to include a Fixes #273
and re-push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @raravena80, thanks for the new guide.
Can you also add a link to this document in Installing on a cloud service platform?
Hi @raravena80 - I forgot to say, could you also add a link to the new AWS doc to the following on this PR: |
@jodh-intel @marcov made the changes and also added a link to it from https://github.com/kata-containers/documentation/blob/master/install/README.md#installing-on-a-cloud-service-platform. PTAL. Thx! Looks like travis is failing with:
And |
46acd78
to
6fa8655
Compare
Thanks @raravena80. We can always finesse the doc to use lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @raravena80 - I should have looked at the bottom of the page first :) The CI is failing and I've made a few suggestions as to how to resolve that.
Did the travis doc processing get fixed? I still see:
|
@grahamwhaley - see #272 (comment). |
@jodh-intel @grahamwhaley looks like now it thinks
|
@raravena80 :-) - looks like an URL on my screen ;-) /me leaves it for @jodh-intel to contemplate.. |
@jodh-intel any updates? |
@raravena80 - That issue is fixed on kata-containers/tests#838. |
kata-containers/tests#838 has now landed so this should pass the CI now. Let's see... lgtm /test |
Fixes kata-containers#273 Installation guide for AWS. Signed-off-by: Ricardo Aravena <raravena@branch.io>
image-builder: share the mkfs configuration file
Installation guide for AWS.
cc: @annabellebertooch
Signed-off-by: Ricardo Aravena raravena@branch.io