Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

install: Add AWS installation guide #272

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

raravena80
Copy link
Member

Installation guide for AWS.

cc: @annabellebertooch

Signed-off-by: Ricardo Aravena raravena@branch.io

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raravena80 - Thanks for raising - this is going to be a really useful resource!

I've added a few comments mostly around consistency with our existing docs.

Also, Travis is failing since our checkcommits tool is complaining there is no "Fixes #XXX" comment in you commit, and pointing you to:

I've raised #273 for you so can amend your commit to include a Fixes #273 and re-push.

install/aws-installation-guide.md Outdated Show resolved Hide resolved
install/aws-installation-guide.md Outdated Show resolved Hide resolved
install/aws-installation-guide.md Outdated Show resolved Hide resolved
install/aws-installation-guide.md Outdated Show resolved Hide resolved
install/aws-installation-guide.md Show resolved Hide resolved
install/aws-installation-guide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marcov marcov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raravena80, thanks for the new guide.

Can you also add a link to this document in Installing on a cloud service platform?

install/aws-installation-guide.md Outdated Show resolved Hide resolved
install/aws-installation-guide.md Outdated Show resolved Hide resolved
@jodh-intel
Copy link
Contributor

Hi @raravena80 - I forgot to say, could you also add a link to the new AWS doc to the following on this PR:

@raravena80
Copy link
Member Author

raravena80 commented Oct 17, 2018

@jodh-intel @marcov made the changes and also added a link to it from https://github.com/kata-containers/documentation/blob/master/install/README.md#installing-on-a-cloud-service-platform. PTAL. Thx!

Looks like travis is failing with:

package mvdan.cc/xurls/cmd/xurls: unrecognized import path "mvdan.cc/xurls/cmd/xurls" (https fetch: Get https://mvdan.cc/xurls/cmd/xurls?go-get=1: dial tcp 178.62.67.243:443: i/o timeout)```

And shell code invalid. I can't find which is one is actually failing on.

install/aws-installation-guide.md Outdated Show resolved Hide resolved
install/aws-installation-guide.md Outdated Show resolved Hide resolved
@raravena80 raravena80 force-pushed the master branch 2 times, most recently from 46acd78 to 6fa8655 Compare October 17, 2018 18:13
install/aws-installation-guide.md Outdated Show resolved Hide resolved
install/README.md Show resolved Hide resolved
@jodh-intel
Copy link
Contributor

jodh-intel commented Oct 19, 2018

Thanks @raravena80.

We can always finesse the doc to use jq at a later date. I think it's more important that we land it so...

lgtm

Approved with PullApprove Approved with PullApprove

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raravena80 - I should have looked at the bottom of the page first :) The CI is failing and I've made a few suggestions as to how to resolve that.

install/aws-installation-guide.md Outdated Show resolved Hide resolved
install/aws-installation-guide.md Show resolved Hide resolved
install/aws-installation-guide.md Outdated Show resolved Hide resolved
install/aws-installation-guide.md Outdated Show resolved Hide resolved
@grahamwhaley
Copy link
Contributor

Did the travis doc processing get fixed? I still see:

INFO: processing file 'install/aws-installation-guide.md'
ERROR: shell code in file 'install/aws-installation-guide.md' is not valid

@jodh-intel
Copy link
Contributor

@grahamwhaley - see #272 (comment).

@raravena80
Copy link
Member Author

@jodh-intel @grahamwhaley looks like now it thinks file://MyKeyPair.pub should be a URL:

ERROR: Invalid URL 'file://MyKeyPair.pub' found in the following files:

@grahamwhaley
Copy link
Contributor

@raravena80 :-) - looks like an URL on my screen ;-) /me leaves it for @jodh-intel to contemplate..

@raravena80
Copy link
Member Author

@jodh-intel any updates?

@jodh-intel
Copy link
Contributor

@raravena80 - That issue is fixed on kata-containers/tests#838.

install/aws-installation-guide.md Outdated Show resolved Hide resolved
install/aws-installation-guide.md Outdated Show resolved Hide resolved
@jodh-intel
Copy link
Contributor

kata-containers/tests#838 has now landed so this should pass the CI now. Let's see...

lgtm

/test

Fixes kata-containers#273

Installation guide for AWS.

Signed-off-by: Ricardo Aravena <raravena@branch.io>
@egernst egernst merged commit a184f98 into kata-containers:master Oct 26, 2018
devimc pushed a commit to devimc/kata-documentation that referenced this pull request Sep 2, 2019
image-builder: share the mkfs configuration file
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants