-
Notifications
You must be signed in to change notification settings - Fork 302
minikube: note kata-fc does not function under minikube #527
minikube: note kata-fc does not function under minikube #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grahamwhaley thanks for the update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -32,6 +32,10 @@ This installation guide has only been verified under a Minikube Linux installati | |||
> - This installation guide may not work for macOS installations of Minikube, due to the lack of | |||
nested virtualization support on that platform. | |||
> - This installation guide has not been tested on a Windows installation. | |||
> - Kata under Minikube does not currently support Kata Firecracker (`kata-fc`), due to | |||
> lack of a block based storage driver availability. Although the `kata-fc` binary will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think the word "availability" is redundant?
due to the lack of a block based storage driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, given the thread that spawned this update, I quite like the way it confirms why there is a lack of driver... implies that it is not something one can just go update/fix trivially. I'll change it if you really want though...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just doesn't read well to me, but I'm struggling to think how to improve the wording. I'll ack and see if @klynnrif has any thoughts...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np. I simplified and dropped the whole section about why it will not work, and now just note it won't work... (and, the reasons why may change or be incomplete, so just saying 'does not work' should have a longer shelf life, until the day it does work...)
`kata-fc` does not presently function under `minikube` due to lack of block based storage. Make that clear in the installation documents, to help prevent users going through the whole install process, only to be disappointed when they find ti does not work. Fixes: kata-containers#526 Signed-off-by: Graham Whaley <graham.whaley@intel.com>
e55565e
to
675f221
Compare
/test |
kata-fc
does not presently function underminikube
due tolack of block based storage. Make that clear in the installation
documents, to help prevent users going through the whole install
process, only to be disappointed when they find ti does not work.
Fixes: #526
Signed-off-by: Graham Whaley graham.whaley@intel.com