-
Notifications
You must be signed in to change notification settings - Fork 302
Conversation
708d699
to
0752592
Compare
There is simply no such thing as upgrading from runv. kata is a fresh installation and it can even run together with runv without affecting each other. |
0752592
to
135471b
Compare
Hi @bergwolf - I thought that would be the case. Are you happy for this doc to land and then potentially for someone to raise a follow-on PR to update this doc explaining the runv approach? |
@jodh-intel yes, that's fine with me. I'll raise a PR to add the runv approach after this is landed. |
Great - thanks @bergwolf. |
@jodh-intel looks good - I'll be giving a try today to make sure it works in my clear-containers dev machine. |
Assuming someone (@jcvenegas ) tests/verifies, the text and plan looks great to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scrubbed for grammar, structure, and flow. Thanks!
Upgrading.md
Outdated
|
||
> **Warning**: If you have modified your | ||
> [Clear Containers configuration](https://github.com/clearcontainers/runtime#configuration), | ||
> you may wish to make a safe copy of the configuration file before removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to make a safe copy...
Upgrading.md
Outdated
|
||
Kata Containers requires additional resources to create a virtual machine | ||
container. These resources are called | ||
[Kata Containers assets](https://github.com/kata-containers/documentation/blob/master/architecture.md#assets) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add in a comma after "Kata Containers assets"
Upgrading.md
Outdated
Since the official assets are packaged, they are automatically upgraded when | ||
new package versions are published. | ||
|
||
> **Warning**: Note that if you are using custom assets (by modifying the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning: Note that if you use custom assets (by modifying the
Upgrading.md
Outdated
The `kata-linux-container` package contains a Linux\* kernel based on the | ||
latest vanilla version of the | ||
[longterm kernel](https://www.kernel.org/) | ||
and including a small number of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "and include"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find a good way to write this using "include", so I've changed it to "plus" ;)
Upgrading.md
Outdated
|
||
The `Longterm` branch is only updated with | ||
[important bug fixes](https://www.kernel.org/category/releases.html) | ||
meaning this package will only be updated when necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meaning this package is only updated when necessary.
Upgrading.md
Outdated
[important bug fixes](https://www.kernel.org/category/releases.html) | ||
meaning this package will only be updated when necessary. | ||
|
||
The guest kernel package will be updated when a new longerm kernel is released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rewrite + missing "t" in "longterm": The guest kernel package is updated when a new longterm kernel is released
Add a document explaining how to upgrade a system: - Running Clear Containers. - Already installed with Kata Containers binaries. Also, include details of assets and how and when the are updated. Fixes kata-containers#69, fixes kata-containers#78. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
135471b
to
603a40a
Compare
Thanks @klynnrif - branch updated. |
I'm happy to see it merged -- @klynnrif can you take a look please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thanks!
initrd-builder: fix initrd image name
Add a document explaining how to upgrade a system:
Fixes #78.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com