Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

show summary of image sizes at end of tests #162

Closed
jodh-intel opened this issue Sep 7, 2018 · 5 comments
Closed

show summary of image sizes at end of tests #162

jodh-intel opened this issue Sep 7, 2018 · 5 comments
Assignees

Comments

@jodh-intel
Copy link
Contributor

It would be useful to see a formatted list of the images and initrds at the end of the test, showing the sizes of each.

@jodh-intel jodh-intel self-assigned this Sep 7, 2018
jodh-intel added a commit to jodh-intel/osbuilder-1 that referenced this issue Sep 7, 2018
At the end of the tests, show a summary of the sizes of all the images
and initrds along with their sizes.

Fixes kata-containers#162.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@egernst egernst added the review label Sep 7, 2018
jodh-intel added a commit to jodh-intel/osbuilder-1 that referenced this issue Sep 7, 2018
At the end of the tests, show a summary of the sizes of all the images
and initrds along with their sizes.

Fixes kata-containers#162.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@marcov
Copy link
Contributor

marcov commented Sep 7, 2018

Currently images size is set to always be 512MB:

IMG_SIZE=500

qemu-img create -q -f raw "${IMAGE}" "${IMG_SIZE}M"

jodh-intel added a commit to jodh-intel/osbuilder-1 that referenced this issue Sep 9, 2018
At the end of the tests, show a summary of the sizes of all the images
and initrds along with their sizes.

Fixes kata-containers#162.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel added a commit to jodh-intel/osbuilder-1 that referenced this issue Sep 9, 2018
At the end of the tests, show a summary of the sizes of all the images
and initrds along with their sizes.

Fixes kata-containers#162.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel added a commit to jodh-intel/osbuilder-1 that referenced this issue Sep 9, 2018
At the end of the tests, show a summary of the sizes of all the images
and initrds along with their sizes.

Fixes kata-containers#162.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel added a commit to jodh-intel/osbuilder-1 that referenced this issue Sep 10, 2018
At the end of the tests, show a summary of the sizes of all the images
and initrds along with their sizes.

Fixes kata-containers#162.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel
Copy link
Contributor Author

Hi @marcov - actually, that's just a starting size - note that create_rootfs_disk() is called recursively! :-)

See also: #30.

@grahamwhaley
Copy link
Contributor

iirc, we do still round up to a nice boundary though on the actual .img file size. What we really want to see is more like a 'df' of what is inside the image (so we could loop mount and have a peek maybe), or really really something like a PSS measure running a single docker busybox sh or something like the memory consumed in the container test. What I think we are really interested in is the runtime impact on both the host and guest.

@marcov
Copy link
Contributor

marcov commented Sep 10, 2018

@grahamwhaley: how is PSS affected by the rootfs size? Is it because we cache in memory the guest filesystem?

jodh-intel added a commit to jodh-intel/osbuilder-1 that referenced this issue Sep 10, 2018
At the end of the tests, show a summary of the size of all the rootfs's,
images and initrd's.

Fixes kata-containers#162.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@grahamwhaley
Copy link
Contributor

@marcov tbh, I'm not sure it is. It might be that QEMU has to cache more or construct more (larger) structures to do the mappings etc. It is probably more likely that the costs on the host side will be in the host side kernel (page tables etc.) maybe, which we'd see with the system level density test. But, that test is probably not going to give a stable result when running a single container.

jodh-intel added a commit to jodh-intel/osbuilder-1 that referenced this issue Sep 10, 2018
At the end of the tests, show a summary of the size of all the rootfs's,
images and initrd's.

Fixes kata-containers#162.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel added a commit to jodh-intel/osbuilder-1 that referenced this issue Sep 10, 2018
At the end of the tests, show a summary of the size of all the rootfs's,
images and initrd's.

Fixes kata-containers#162.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@egernst egernst removed the review label Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants