This repository has been archived by the owner on May 12, 2021. It is now read-only.
rootfs: Include libseccomp support in rootfs #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the image used on the guest does include libseccomp, otherwise when a seccomp profile is passed by the runtime, it will end up with boot failure on the guest. Fixes: #153 Signed-off-by: Nitesh Konkar niteshkonkar@in.ibm.com
|
I guess #154 takes care of this as well. |
|
lgtm The only question is whether we want to make this package configurable to keep the size as minimal as possible - see kata-containers/agent#353 (comment). 16.04 CI restarted (network error) |
|
@nitkon: any reasons why |
|
Never mind, just saw #152. Is it actually required for all distros? |
|
@nitkon ok, thanks |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the image used on the guest does include libseccomp,
otherwise when a seccomp profile is passed by the runtime, it
will end up with boot failure on the guest.
Fixes: #153
Signed-off-by: Nitesh Konkar niteshkonkar@in.ibm.com