Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Makefile: update targets to better track build artifacts #159

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

marcov
Copy link
Contributor

@marcov marcov commented Sep 6, 2018

Update Makefile so that build artifacts are actually tracked as make targets. This is to enforce a strict prerequisite ordering and better handle parallel builds.

Fixes: #157

@marcov
Copy link
Contributor Author

marcov commented Sep 6, 2018

Realized I need to update README.md too.

Update Makefile so that build artifacts are actually tracked as make
targets. This is to enforce a strict prerequisite ordering and better
handle parallel builds.

Fixes: kata-containers#157

Signed-off-by: Marco Vedovati <mvedovati@suse.com>
@jodh-intel
Copy link
Contributor

Thanks @marcov!

lgtm

@marcov
Copy link
Contributor Author

marcov commented Sep 6, 2018

@jodh-intel tests are failing, looks like this is the reason but cant say for sure:

Error downloading packages:
  procps-ng-3.3.10-17.2.h5.x86_64: [Errno 256] No more mirrors to try.
  krb5-libs-1.14.1-26.h2.x86_64: [Errno 256] No more mirrors to try.

The command '/bin/sh -c yum -y update && yum install -y yum git make gcc coreutils' returned a non-zero code: 1
INFO: ERROR: test failed

@jodh-intel
Copy link
Contributor

@marcov - yep, looks like a euleros issue (probably network). I've restarted it on 16.04 to see if it's transitory.

@jcvenegas
Copy link
Member

@marcov @jodh-intel eulerOS failed again, restarting one more time...

@jcvenegas
Copy link
Member

jcvenegas commented Sep 6, 2018

lgtm

Approved with PullApprove

@jcvenegas
Copy link
Member

@kata-containers/documentation ping

@jodh-intel
Copy link
Contributor

Restarting failing CI's again...

@marcov
Copy link
Contributor Author

marcov commented Sep 7, 2018

tests are happy now 😄

@jodh-intel
Copy link
Contributor

jodh-intel commented Sep 7, 2018

lgtm.

Overriding pullapprove as a doc review is not required (code block changes only):

Approved with PullApprove Approved with PullApprove

@jodh-intel jodh-intel merged commit 93ad049 into kata-containers:master Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants