kernel: Add 4.19.8 config for x86 #278

sboeuf · 2018-12-10T05:27:23Z

We want to make sure Kata runs on latest stable kernels so that it
benefits from the latest features.

For instance, in case of Kata relying on NEMU hypervisor, the recent
kernel patches reworking the way timer calibration is handled are
solving some boot latency issues.

Signed-off-by: Sebastien Boeuf sebastien.boeuf@intel.com

sboeuf · 2018-12-10T05:32:14Z

@jcvenegas here is the configuration that we need after I have reused the one from 4.14.x. The only thing I had to say Y was the new VIRTIO_MENU config option.

Both patches 0001(9p) and 0002(evged) applied properly. Problem with 0003 is that it's not needed since it's already part of the stable release 4.19.8. How do you want to handle this? I'm asking cause we have other architectures relying on 4.14.x, thinking about s390, that needs this patch.

Should we bump all architectures to 4.19.8? I don't have the hardware to check that what I'm doing is okay for other archs...

Let me know how we should proceed here.

sboeuf · 2018-12-10T05:32:46Z

/cc @rbradford

jodh-intel · 2018-12-10T09:59:55Z

ping @kata-containers/kernel, @alicefr.

Pennyzct · 2018-12-10T10:18:22Z

Hi~@sboeuf
I have already fired a PR #269 to bump arm guest kernel to 4.19.4 for supporting nvdimm on arm64.
And with regards to applying patches, in that pr, I have classified them based on arch.
I think that both patches 0001(9p) and 0002(evged) are generally applied for all arches and 003 is just for s390x. Wdyt?
Also, I pulled a related PR in runtime repo to refine file version.yaml to let the kernel config also arch-dependent. ;)

Weichen81 · 2018-12-10T10:39:33Z

For Arm64, we’re welcome 4.19.x ;)

alicefr · 2018-12-10T12:16:16Z

@Pennyzct 003 is s390 specific but it's applied to all arch. It could be that the patch doesn't apply to the 4.19. I need to check. The patch has been upstreamed since version 4.16

alicefr · 2018-12-10T12:18:30Z

Otherwise I'll fix it and also generate the s390x configs :)

marcov · 2018-12-10T12:22:03Z

I think that in the master branch we should just keep one set of configs & patches that applies to the kernel version specified in runtime/versions.yaml, hence we should delete old configs & patches.

We have stable- branches to keep older config versions.

The process should be:

update runtime/versions.yaml
update configs / patches in packaging

marcov · 2018-12-10T12:23:33Z

@Pennyzct would it be OK to converge to this same kernel version for ARM? It would make life easier for packaging.

Pennyzct · 2018-12-10T12:39:25Z

hi~ @alicefr @marcov sure, let's keep one set. I will update my PR to follow the latest 4.19.8 and delete arch-dependent code in related PR. ;)

alicefr · 2018-12-10T12:55:53Z

@marcov should I open a PR for the s390 configs?I still need to test the kernel but I can do it quickly

marcov · 2018-12-10T13:45:24Z

@Pennyzct thanks!

@alicefr you can open a PR to update the s390 config to 4.19.8, and thank you for testing it.

alicefr · 2018-12-10T14:19:05Z

@marcov do I need to remove the s390 config 4.14 and the patch in the same PR? This PR #275 would also be worthless

marcov · 2018-12-10T14:26:06Z

@alicefr I think so. If it's possible, do a git mv to retain the file history. This is also what @Pennyzct is doing in #269.

Do you agree with this @sboeuf, @jodh-intel?

marcov · 2018-12-10T14:28:46Z

@alicefr if #275 gets merged soon you can keep it, and open a new PR for the version bump.

devimc · 2018-12-10T15:11:26Z

kernel/configs/x86_64_kata_kvm_4.19.8

+CONFIG_CLKBLD_I8253=y
+CONFIG_MAILBOX=y
+CONFIG_PCC=y
+


as far as I know kata doesn't support modules, please remove them

Oh yes you're right, I haven't noticed they've been added.

sboeuf · 2018-12-11T05:15:44Z

@marcov @alicefr
Removing the patch 0003 from the list of patches would be ideal in a PR bumping s390 arch to kernel 4.19.8, and thanks for doing that :)
Once your PR lands, I'll rebase this one, without the need to handle the patch 0003.

jcvenegas · 2018-12-11T07:47:31Z

@sboeuf sorry for the late response for next PRs to avoid conflicts with patches and kernel versions we need to move them to its own directory 4.18.x/patches etc

alicefr · 2018-12-11T10:08:34Z

@sboeuf @marcov @Pennyzct I open a PR #281 that remove the 003 patch and adds the new s390 kernel config. If you decide to keep the 4.14 config let me know and I'll change my PR consequently

jcvenegas

Hi @sboeuf could you rename the file name from x86_64_kata_kvm_4.19.8 to x86_64_kata_kvm_4.19.x ?

sboeuf · 2018-12-12T19:26:09Z

/test

sboeuf · 2018-12-12T19:26:24Z

@jcvenegas @devimc comments addressed!

jodh-intel · 2018-12-13T09:07:52Z

lgtm

marcov · 2018-12-13T09:29:00Z

@sboeuf Can you do a git mv from the 4.14 to 4.19 config? I dont think we should keep 4.14 versioned in master.

We want to make sure Kata runs on latest stable kernels so that it benefits from the latest features. For instance, in case of Kata relying on NEMU hypervisor, the recent kernel patches reworking the way timer calibration is handled are solving some boot latency issues. Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>

sboeuf · 2018-12-14T15:29:50Z

@marcov

Can you do a git mv from the 4.14 to 4.19 config? I dont think we should keep 4.14 versioned in master.

Yes! Done!

sboeuf · 2018-12-14T15:29:55Z

/test

marcov · 2018-12-14T17:40:11Z

lgtm

Resolve issues with markdown in this repo. Fixes #278. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>

sboeuf added the do-not-merge label Dec 10, 2018

devimc reviewed Dec 10, 2018

View reviewed changes

Pennyzct mentioned this pull request Dec 11, 2018

kernel: update guest kernel to 4.19.8 on aarch64 #269

Merged

alicefr mentioned this pull request Dec 11, 2018

kernel: update kernel config for s390 to version 4.19 #280

Closed

alicefr mentioned this pull request Dec 11, 2018

kernel: add s390 config for version 4.19.8 #281

Merged

jcvenegas suggested changes Dec 11, 2018

View reviewed changes

sboeuf force-pushed the add_config_x86_4_19_8 branch from b6cb804 to b62b1dd Compare December 12, 2018 19:21

sboeuf removed the do-not-merge label Dec 12, 2018

sboeuf force-pushed the add_config_x86_4_19_8 branch from b62b1dd to 9ec1ca7 Compare December 14, 2018 15:28

mcastelino merged commit 9d4e6b0 into kata-containers:master Dec 14, 2018

mcastelino mentioned this pull request Dec 15, 2018

Revert "kernel: Add 4.19.8 config for x86" #283

Merged

jcvenegas pushed a commit that referenced this pull request Jul 2, 2019

docs: Fix markdown

c5a17f7

Resolve issues with markdown in this repo. Fixes #278. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kernel: Add 4.19.8 config for x86 #278

kernel: Add 4.19.8 config for x86 #278

sboeuf commented Dec 10, 2018

sboeuf commented Dec 10, 2018

sboeuf commented Dec 10, 2018

jodh-intel commented Dec 10, 2018

Pennyzct commented Dec 10, 2018 •

edited

Loading

Weichen81 commented Dec 10, 2018

alicefr commented Dec 10, 2018

alicefr commented Dec 10, 2018

marcov commented Dec 10, 2018

marcov commented Dec 10, 2018

Pennyzct commented Dec 10, 2018

alicefr commented Dec 10, 2018

marcov commented Dec 10, 2018

alicefr commented Dec 10, 2018

marcov commented Dec 10, 2018

marcov commented Dec 10, 2018

devimc Dec 10, 2018

sboeuf Dec 11, 2018

sboeuf commented Dec 11, 2018

jcvenegas commented Dec 11, 2018

alicefr commented Dec 11, 2018

jcvenegas left a comment

sboeuf commented Dec 12, 2018

sboeuf commented Dec 12, 2018

jodh-intel commented Dec 13, 2018 •

edited by amshinde

Loading

marcov commented Dec 13, 2018

sboeuf commented Dec 14, 2018

sboeuf commented Dec 14, 2018

marcov commented Dec 14, 2018 •

edited by amshinde

Loading

kernel: Add 4.19.8 config for x86 #278

kernel: Add 4.19.8 config for x86 #278

Conversation

sboeuf commented Dec 10, 2018

sboeuf commented Dec 10, 2018

sboeuf commented Dec 10, 2018

jodh-intel commented Dec 10, 2018

Pennyzct commented Dec 10, 2018 • edited Loading

Weichen81 commented Dec 10, 2018

alicefr commented Dec 10, 2018

alicefr commented Dec 10, 2018

marcov commented Dec 10, 2018

marcov commented Dec 10, 2018

Pennyzct commented Dec 10, 2018

alicefr commented Dec 10, 2018

marcov commented Dec 10, 2018

alicefr commented Dec 10, 2018

marcov commented Dec 10, 2018

marcov commented Dec 10, 2018

devimc Dec 10, 2018

Choose a reason for hiding this comment

sboeuf Dec 11, 2018

Choose a reason for hiding this comment

sboeuf commented Dec 11, 2018

jcvenegas commented Dec 11, 2018

alicefr commented Dec 11, 2018

jcvenegas left a comment

Choose a reason for hiding this comment

sboeuf commented Dec 12, 2018

sboeuf commented Dec 12, 2018

jodh-intel commented Dec 13, 2018 • edited by amshinde Loading

marcov commented Dec 13, 2018

sboeuf commented Dec 14, 2018

sboeuf commented Dec 14, 2018

marcov commented Dec 14, 2018 • edited by amshinde Loading

Pennyzct commented Dec 10, 2018 •

edited

Loading

jodh-intel commented Dec 13, 2018 •

edited by amshinde

Loading

marcov commented Dec 14, 2018 •

edited by amshinde

Loading