This repository has been archived by the owner on May 12, 2021. It is now read-only.
kata-deploy: All binaries installed by kata should be writable by root #494
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, some of the binaries installed by kata were not owned by root. Any user can write/replace these binaries. This was happening as tar perserves ownership while creating the archive. Change the ownership of all binaries to root. Fixes kata-containers#489 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
krsna1729
approved these changes
May 8, 2019
devimc
approved these changes
May 8, 2019
|
/test |
egernst
approved these changes
May 9, 2019
|
/test |
jodh-intel
approved these changes
May 9, 2019
There was a problem hiding this comment.
lgtm
ftr, I've also updated the long-standing packaging test issue to cover this scenario as an explicit test too: kata-containers/ci#10.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, some of the binaries installed by kata were not owned by
root. Any user can write/replace these binaries.
This was happening as tar perserves ownership while creating the
archive.
Change the ownership of all binaries to root.
Fixes #489
Signed-off-by: Archana Shinde archana.m.shinde@intel.com