Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Config changes for 5.4 kernel #925

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Conversation

amshinde
Copy link
Member

No description provided.

The whitelist contains options that we dont really care.
Always apply it, irrespective of if we are using an
experimental kernel.

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
Dont think these are options are required at all.
Remove them from fragments and whitelist.

Fixes kata-containers#924

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
amshinde added a commit to amshinde/kata-runtime that referenced this pull request Feb 10, 2020
Depends-on: github.com/kata-containers/packaging#925

Fixes: kata-containers#2421

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
@devimc
Copy link

devimc commented Feb 10, 2020

/test

@egernst
Copy link
Member

egernst commented Feb 10, 2020

/test kata-deploy

Copy link
Member

@egernst egernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amshinde

This sounds mostly okay, though if we never care about the item, it makes me take pause and wonder if we really need it in the first place. We certainly don't need it for 5.4, but I'm concerned that we're going to get in a situation where folks want to support multiple kernels on the same branch of Kata (ie, 4.19 and 5.4 in latest relaese of kata, for example).

@amshinde
Copy link
Member Author

We certainly don't need it for 5.4, but I'm concerned that we're going to get in a situation where folks want to support multiple kernels on the same branch of Kata (ie, 4.19 and 5.4 in latest relaese of kata, for example).

So what do you suggest, have a separate whitelist per kernel version?

amshinde added a commit to amshinde/kata-runtime that referenced this pull request Feb 11, 2020
Depends-on: github.com/kata-containers/packaging#925

Fixes: kata-containers#2421

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
@amshinde amshinde added the do-not-merge PR has problems or depends on another label Feb 11, 2020
@jcvenegas
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@chavafg
Copy link
Contributor

chavafg commented Feb 17, 2020

is this ready? should we remove the DNM label?
Needed to unblock CI. kata-containers/runtime#2422 is already merged

@jcvenegas
Copy link
Member

@amshinde @chavafg actually the packages are broken there needs to be updated, @amshinde because the CI in general is merged, can be merged and fix it in a separate PR

@chavafg
Copy link
Contributor

chavafg commented Feb 17, 2020

ok, thanks @jcvenegas
+1 to unblock the CI

@chavafg chavafg removed the do-not-merge PR has problems or depends on another label Feb 17, 2020
@jcvenegas jcvenegas merged commit 901f9ba into kata-containers:master Feb 17, 2020
evanfoster pushed a commit to evanfoster/runtime that referenced this pull request Mar 9, 2020
Depends-on: github.com/kata-containers/packaging#925

Fixes: kata-containers#2421

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants