-
Notifications
You must be signed in to change notification settings - Fork 92
Conversation
The whitelist contains options that we dont really care. Always apply it, irrespective of if we are using an experimental kernel. Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
Dont think these are options are required at all. Remove them from fragments and whitelist. Fixes kata-containers#924 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
Depends-on: github.com/kata-containers/packaging#925 Fixes: kata-containers#2421 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
/test |
/test kata-deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amshinde
This sounds mostly okay, though if we never care about the item, it makes me take pause and wonder if we really need it in the first place. We certainly don't need it for 5.4, but I'm concerned that we're going to get in a situation where folks want to support multiple kernels on the same branch of Kata (ie, 4.19 and 5.4 in latest relaese of kata, for example).
So what do you suggest, have a separate whitelist per kernel version? |
Depends-on: github.com/kata-containers/packaging#925 Fixes: kata-containers#2421 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
is this ready? should we remove the DNM label? |
ok, thanks @jcvenegas |
Depends-on: github.com/kata-containers/packaging#925 Fixes: kata-containers#2421 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
No description provided.