-
Notifications
You must be signed in to change notification settings - Fork 55
vendor: Add missing package dependencies #54
Conversation
Update the vendoring to include missing packages the proxy relies on. Fixes kata-containers#53. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
3702722
to
eb61997
Compare
Hi @sboeuf - could you take a look? |
Q. - we don't seem to have the dep [prune] section here in the toml file - is now maybe the time to add it? |
@jodh-intel I agree with @grahamwhaley that you should also update the Gopkg.toml the same way we did for other repos, so that it take into account the new |
Sorry I hit the wrong button.... |
Update the `dep` config file to automatically prune when `dep ensure` is run from now on. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Good call. I've updated the |
Fix a couple of issues identified by the CI calling `staticcheck`. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
I managed to unbreak it! 😄 Presumably, some of these issues are the result of our CI changing over time. |
@jodh-intel cool thx ! |
We are getting this on the CI:
is that just an artifact of some PR merge race maybe - something to fix, or ignore and merge?? |
That error is coming from the @chavafg - could you investigate? |
@grahamwhaley, @jodh-intel the CI failed because #56 is still not merged. |
Update the vendoring to include missing packages the proxy relies on.
Fixes #53.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com