vc: Persist file handle may leak in FS#ToDisk

Fixes #2241 Signed-off-by: Ted Yu <yuzhihong@gmail.com>
kata-containers · Nov 21, 2019 · b8b6733 · b8b6733
1 parent a17ca14
commit b8b6733
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/virtcontainers/persist/fs/fs.go b/virtcontainers/persist/fs/fs.go
@@ -139,10 +139,10 @@ func (fs *FS) ToDisk(ss persistapi.SandboxState, cs map[string]persistapi.Contai
 			return err
 		}
 
+		defer cf.Close()
 		if err := json.NewEncoder(cf).Encode(cstate); err != nil {
 			return err
 		}
-		cf.Close()
 	}
 
 	return nil