Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

fail to bind vfio device back to host when stopping sandbox #1968

Closed
bergwolf opened this issue Aug 15, 2019 · 0 comments
Closed

fail to bind vfio device back to host when stopping sandbox #1968

bergwolf opened this issue Aug 15, 2019 · 0 comments
Labels
bug Incorrect behaviour

Comments

@bergwolf
Copy link
Member

Description of problem

#1957 is problematic that it causes vfio nic passthrough to fail, because we need to bind the device back to host and that is not possible when qemu is still running. So we should revert it.

And to fix the original issue #1956, we can just skip hotunplug all together as it is not really necessary when stopping a vm.
@bergwolf bergwolf added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Aug 15, 2019
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Aug 15, 2019
@bergwolf
network: always cold unplug network devices
a5811b9 
We don't really need to unplug it from guest because we have
already stopped it. Just detach it and clean it up.

Fixes: kata-containers#1968
Signed-off-by: Peng Tao <bergwolf@hyper.sh>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Aug 15, 2019
@bergwolf
network: always cold unplug network devices
e04b1e1 
We don't really need to unplug it from guest because we have
already stopped it. Just detach it and clean it up.

Fixes: kata-containers#1968
Signed-off-by: Peng Tao <bergwolf@hyper.sh>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Aug 15, 2019
@bergwolf
network: always cold unplug network devices
0d24775 
We don't really need to unplug it from guest because we have
already stopped it. Just detach it and clean it up.

Fixes: kata-containers#1968
Signed-off-by: Peng Tao <bergwolf@hyper.sh>
@devimc devimc closed this as completed in d90eba8 Aug 15, 2019
@egernst egernst removed the needs-review Needs to be assessed by the team. label Aug 15, 2019
egernst pushed a commit to egernst/runtime that referenced this issue Aug 29, 2019
@bergwolf
network: always cold unplug network devices
6af47f6 
We don't really need to unplug it from guest because we have
already stopped it. Just detach it and clean it up.

Fixes: kata-containers#1968
Signed-off-by: Peng Tao <bergwolf@hyper.sh>
vijaydhanraj pushed a commit to vijaydhanraj/runtime that referenced this issue Sep 3, 2019
@bergwolf @vijaydhanraj
network: always cold unplug network devices
804c80b 
We don't really need to unplug it from guest because we have
already stopped it. Just detach it and clean it up.

Fixes: kata-containers#1968
Signed-off-by: Peng Tao <bergwolf@hyper.sh>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bergwolf @egernst