Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Unbreak tracing test #2264

Closed
jodh-intel opened this issue Nov 25, 2019 · 0 comments · Fixed by #2265
Closed

Unbreak tracing test #2264

jodh-intel opened this issue Nov 25, 2019 · 0 comments · Fixed by #2265
Assignees
@jodh-intel

Comments

@jodh-intel
Copy link
Contributor

The tracing test needs Jaeger to log when it reports a span. Force this to happen.

I'm rather confused as I could have sworn we used to have this code in all traceable components. We certainly have it in the agent but it's missing from the runtime and the shim.
@jodh-intel jodh-intel self-assigned this Nov 25, 2019
jodh-intel added a commit to jodh-intel/runtimes that referenced this issue Nov 25, 2019
@jodh-intel
tracing: Unbreak tracing test
330cc72 
Force Jaeger to log when it reports traces to ensure the tracing test
[1] works as expected.

Fixes: kata-containers#2264.

[1] - https://github.com/kata-containers/tests/blob/master/tracing/tracing-test.sh

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
This was referenced Nov 25, 2019
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jodh-intel jodh-intel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tracing: Unbreak tracing test jodh-intel/runtimes
1 participant
@jodh-intel