This repository has been archived by the owner on May 12, 2021. It is now read-only.
unit-test: cleaning up stale files under /tmp #2398
Labels
enhancement
Improvement to an existing feature
needs-review
Needs to be assessed by the team.
wip
Work in Progress (PR incomplete - needs more work or rework)
Comments
Pennyzct
added
enhancement
Pennyzct
added a commit
to Pennyzct/runtime
that referenced
this issue
Jan 17, 2020
Normally, ioutil.TempDir will create a new temporary dir under /tmp. And we should do cleaning up after ioutil.TempDir(). Fixes: kata-containers#2398 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Pennyzct
added
the
wip
Pennyzct
added a commit
to Pennyzct/runtime
that referenced
this issue
Jan 17, 2020
ioutil.TempFile creates a new temporary file in the directory dir. It is the caller's responsibility to remove the file when no longer needed. Fixes: kata-containers#2398 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I've found a few unit tests which were generating stale files under
/tmp- Using
deferin TestMain.os.Exit will skip all deferred instructions.
So we should reconstruct TestMain to leave all setup-related code in setup(), and all cleanup-related code in shutdown().
- Missing deleting what
ioutil.TempDir()createsNormally,
ioutil.TempDirwill create a new temporary dir under/tmp.PR is on the fly~~~~
The text was updated successfully, but these errors were encountered: