Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

logging: drop default OCI runtime log level from Into to Warn #2522

Closed
grahamwhaley opened this issue Mar 10, 2020 · 1 comment
Closed

logging: drop default OCI runtime log level from Into to Warn #2522

grahamwhaley opened this issue Mar 10, 2020 · 1 comment
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@grahamwhaley
Copy link
Contributor

Which feature do you think can be improved?

OCI kata runtime logs at a default level of Info, which is quite noisy in the logs.
When used as the containerd shimv2 runtime, the default (inherited from containerd itself) is Warn, which is much quieter, but still tells you of warnings and errors.

How can it be improved?

Let's drop the OCI runtime log level down to Warn, to save our end users log space and bandwidth - I really doubt anybody reads the Info logs....

Additional Information

We should consider if this will harm our, or our user, debug flow.
We probably want to cast a net to known active users to see if this might affect their current setup at all.

And as a side note, presently there is no way to enable anything else other than Debug level - so presently you can only go from Info->Debug, and can not afaik set a Warn level. With this change you will only be able to go from Warn->Debug level, with no mechanism to set an Info level. Adding the ability to choose nay default level would be a different Issue/PR I think.

@grahamwhaley grahamwhaley added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Mar 10, 2020
@grahamwhaley
Copy link
Contributor Author

I should note, we use logrus, and it has its levels documented here, with a hint that the default level is Info, and you can find that in the code here where it constructs the default logger I believe.

grahamwhaley pushed a commit to grahamwhaley/kata-containers-runtime that referenced this issue Mar 10, 2020
Set the default log level explicitly to 'Warn', rather than taking
the logrus default (which is normally 'Info').

Fixes: kata-containers#2522

Signed-off-by: Graham Whaley <graham.whaley@intel.com>
grahamwhaley pushed a commit to grahamwhaley/kata-containers-runtime that referenced this issue Mar 10, 2020
Set the katautils default log level to 'Warn', rather than 'Info',
as 'Info' is rather noisy.

Fixes: kata-containers#2522

Signed-off-by: Graham Whaley <graham.whaley@intel.com>
grahamwhaley pushed a commit to grahamwhaley/kata-containers-runtime that referenced this issue Mar 10, 2020
Set the katautils default log level to 'Warn', rather than 'Info',
as 'Info' is rather noisy.

Fixes: kata-containers#2522

Signed-off-by: Graham Whaley <graham.whaley@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Development

No branches or pull requests

1 participant