-
Notifications
You must be signed in to change notification settings - Fork 374
shimv2: use the runtime config file passed from containerd/cri #1173
Conversation
env var and the protobuf field, which should have higher privilege? |
protobuf > env var > /etc dir > /usr/share/defualt dif |
I have another question with protobuf. if work with old version of containerd, will shimv2 panic due to the lack of a field? |
No, it will check the pointer first as below: For the old version containerd, here the r.Options will be nil. |
68054e6
to
ce7864e
Compare
/test |
ff6dbb6
to
7396a71
Compare
containerd/cri's different runtime handlers can pass different config files to shimv2 by a generic runtime options, by this kata can launch the pods using different VMM for different runtime handlers. Fixes:kata-containers#1082 Signed-off-by: Fupan Li <lifupan@gmail.com>
/test |
@grahamwhaley Is there any thing wrong with CI, the tests have been launched a day ago, but none of them has been scheduled? |
/retest |
hi @lifupan - yep, there was a problem yesterday when a disk filled up and things got stalled/backed up in the queu. I think some jobs then got dropped..... looks like the above action has kicked it into action again ... |
containerd/cri's different runtime handlers can pass different
config files to shimv2 by a generic runtime options, by this kata
can launch the pods using different VMM for different runtime handlers.
Fixes:#1082
Signed-off-by: Fupan Li lifupan@gmail.com