Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

data/kata-collect-data: support kata containers snap #1721

Merged

Conversation

devimc
Copy link

@devimc devimc commented May 21, 2019

Use kata-containers.runtime that is the runtime binary, to
collect the data if the kata-runtime binary is not installed

fixes #1720

Signed-off-by: Julio Montes julio.montes@intel.com

Use `kata-containers.runtime` that is the runtime binary, to
collect the data if the kata-runtime binary is not installed

fixes kata-containers#1720

Signed-off-by: Julio Montes <julio.montes@intel.com>
Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devimc.

lgtm

@jodh-intel
Copy link
Contributor

/test

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Yeah, and this gets more complex if we add the static builds in with kata-qemu, kata-fc and maybe kata-nemu coming along as well.

@jodh-intel jodh-intel merged commit 360ffdc into kata-containers:master May 24, 2019
This was referenced Jun 3, 2019
@devimc devimc deleted the topic/data/kataCollectSupportSnap branch October 9, 2019 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snap: kata-collect-data.sh: cannot find runtime 'kata-runtime'
4 participants