This repository has been archived by the owner on May 12, 2021. It is now read-only.
kata-check: require kvm modules for amd64 #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devimc
reviewed
Aug 20, 2019
cli/kata-check_amd64.go
Outdated
| }, | ||
| kernelModvhostvsock: { | ||
| desc: msgKernelVirtioVhostVsock, | ||
| required: false, |
There was a problem hiding this comment.
vosck is not required, and by default required is false, so I just removed the line as it's redundant.
There was a problem hiding this comment.
I didn't know that by default it's false, can we keep it explicit?
There was a problem hiding this comment.
That's how Go works, but I am happy to set it explicitly to false if this gives more clarity.
KVM/vhost modules are required when using QEMU or firecracker. Fixes: kata-containers#1985 Signed-off-by: Marco Vedovati <mvedovati@suse.com>
|
/test |
1 similar comment
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #1986 +/- ##
==========================================
+ Coverage 52.01% 52.06% +0.05%
==========================================
Files 107 107
Lines 14352 14348 -4
==========================================
+ Hits 7465 7471 +6
+ Misses 5999 5994 -5
+ Partials 888 883 -5 |
Add a test for the checkKernelModules returned error count value. Signed-off-by: Marco Vedovati <mvedovati@suse.com>
|
/test |
|
All tests are good, but we need a pair of reviews :-) Calling in the usual folks 😁 @jodh-intel @grahamwhaley @devimc @jcvenegas |
devimc
approved these changes
Aug 29, 2019
jodh-intel
approved these changes
Aug 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KVM modules are required when using QEMU or firecracker.
Fixes: #1985
Signed-off-by: Marco Vedovati mvedovati@suse.com