This repository has been archived by the owner on May 12, 2021. It is now read-only.
Support "Configuration" in "newstore" feature #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
WeiZhang555
force-pushed
the
persist-storage
branch
2 times, most recently
from
4d4fc2b to
2376d6d
Compare
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #2179 +/- ##
=========================================
Coverage ? 49.05%
=========================================
Files ? 111
Lines ? 16057
Branches ? 0
=========================================
Hits ? 7876
Misses ? 7207
Partials ? 974 |
WeiZhang555
force-pushed
the
persist-storage
branch
from
2376d6d to
9e08f15
Compare
|
/test |
|
/retest |
jodh-intel
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Thanks @WeiZhang555.
lgtm although do you think you could add any more unit tests for this?
|
@jodh-intel Thanks for help reviewing! There're some breaking cases, I will fix them in my free time. I will also add some unit tests later. |
|
/test |
|
/retest |
|
/test |
|
/retest |
|
After a hard debugging, all CI passed now (enabled experimental features for all Jenkins jobs). I'll squash the commits and remove the WIP labels, then waiting for merging now. :-) |
WeiZhang555
force-pushed
the
persist-storage
branch
from
b301341 to
ea29859
Compare
WeiZhang555
changed the title
WeiZhang555
force-pushed
the
persist-storage
branch
from
ea29859 to
af9363d
Compare
Fixes kata-containers#803 Store the configuration data in persist.json. Signed-off-by: Wei Zhang <weizhang555.zw@gmail.com>
WeiZhang555
force-pushed
the
persist-storage
branch
from
af9363d to
7943dd9
Compare
|
/test |
lifupan
approved these changes
Nov 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the configuration file in persist.go.
This is the last file we should support for "newstore" feature, after this, we can safely remove old persistence storage drivers.