Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

kernel: update to 4.19.83 #2185

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Conversation

egernst
Copy link
Member

@egernst egernst commented Nov 12, 2019

Fixes: 1816

Signed-off-by: Eric Ernst eric.ernst@intel.com

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your 'Fixes' has no leading # on the n, so fails the CI.
Also, that is not really a useful commit message - the git log will contain no useful explanation.
Having both the version bump and the code change in the same commit (especially without any explanatory text) looks strange as well.

@jodh-intel
Copy link
Contributor

Also, #1816 was closed in September, so please can you raise a new issue and provide details of why this change is needed?

@egernst
Copy link
Member Author

egernst commented Nov 12, 2019

Pragmatism and laziness. Do we want a duplicate GitHub issue for bumps each time? The rationale for doing a bump should be very clear. If there are specific CVEs we open them seperately. WDYT?

@jodh-intel
Copy link
Contributor

I personally still vote for discrete issues for each bump as referring to a closed issue is confusing.

The laziness factor can be handled by using hub:

$ echo -e "I am the issue title\n\nThis is the body of the description.\nMore body\nHub is cool" | hub issue create -F -

@egernst
Copy link
Member Author

egernst commented Nov 13, 2019

/test

@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@552e940). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2185   +/-   ##
=========================================
  Coverage          ?   50.72%           
=========================================
  Files             ?      111           
  Lines             ?    17370           
  Branches          ?        0           
=========================================
  Hits              ?     8811           
  Misses            ?     7468           
  Partials          ?     1091

@egernst
Copy link
Member Author

egernst commented Nov 14, 2019

Looks like ARM patches aren't applying.

@jongwu @Pennyzct can you PTAL?

@gnawux
Copy link
Member

gnawux commented Nov 14, 2019

@Pennyzct your nightmare unfortunately 😿

@Pennyzct
Copy link
Contributor

@egernst We will update asap.😊
@gnawux I'm REALLY LOOK FORWARD TO see the next LTS version. 😭

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I do think it would be extremely useful for tracking purposes to specify in the commit message why this bump was done (CVE's? features? magic flying unicorns 🦄? That kinda stuff 😄).

@Pennyzct
Copy link
Contributor

Hi @egernst plz bump the version to v4.19.84. It's the latest and will decrease the failed chunks.
I've raised the PR to do the update, and you could add the Depends-on: github.com/kata-containers/packaging#807 to see if ARM CI is working well again. ;)

Fixes: kata-containers#2193
Depends-on: github.com/kata-containers/packaging#807

Signed-off-by: Eric Ernst <eric.ernst@intel.com>
@egernst
Copy link
Member Author

egernst commented Nov 25, 2019

/test

@amshinde
Copy link
Member

@egernst CI does not seem to be very happy.

@egernst
Copy link
Member Author

egernst commented Nov 26, 2019

@Pennyzct ^ still unhappy with patches. Sorry.

Pennyzct added a commit to Pennyzct/packaging that referenced this pull request Nov 27, 2019
we need to do patch update for kernel bump to v4.19.86.

Fixes: kata-containers#806
Depends-on: github.com/kata-containers/runtime#2185

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Pennyzct added a commit to Pennyzct/packaging that referenced this pull request Nov 27, 2019
we need to do patch update for kernel bump to v4.19.86.

Fixes: kata-containers#806
Depends-on: github.com/kata-containers/runtime#2185

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
@Pennyzct
Copy link
Contributor

Pennyzct commented Dec 2, 2019

Hi @egernst
So sorry for the delay.
I have updated my PR to be also v4.19.86. And ARM CI is happy now. ;)

@egernst
Copy link
Member Author

egernst commented Dec 2, 2019

/test

@Pennyzct
Copy link
Contributor

Pennyzct commented Dec 3, 2019

As to the failure on ARM CI:

not ok 1 Expose IP Address

I've addressed related issue kata-containers/ci#229 to fix, and it should be irrelevant to this patch. ;).

@egernst
Copy link
Member Author

egernst commented Dec 3, 2019

rerunning virtio-fs test. If it passes, we should be good to merge.

@jcvenegas jcvenegas merged commit 62cd080 into kata-containers:master Dec 3, 2019
egernst pushed a commit to Pennyzct/packaging that referenced this pull request Dec 3, 2019
we need to do patch update for kernel bump to v4.19.86.

Fixes: kata-containers#806
Depends-on: github.com/kata-containers/runtime#2185

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
@egernst egernst deleted the kernel-bump branch June 26, 2020 05:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants