-
Notifications
You must be signed in to change notification settings - Fork 375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your 'Fixes' has no leading # on the n
, so fails the CI.
Also, that is not really a useful commit message - the git log will contain no useful explanation.
Having both the version bump and the code change in the same commit (especially without any explanatory text) looks strange as well.
Also, #1816 was closed in September, so please can you raise a new issue and provide details of why this change is needed? |
Pragmatism and laziness. Do we want a duplicate GitHub issue for bumps each time? The rationale for doing a bump should be very clear. If there are specific CVEs we open them seperately. WDYT? |
I personally still vote for discrete issues for each bump as referring to a closed issue is confusing. The laziness factor can be handled by using $ echo -e "I am the issue title\n\nThis is the body of the description.\nMore body\nHub is cool" | hub issue create -F - |
/test |
Codecov Report
@@ Coverage Diff @@
## master #2185 +/- ##
=========================================
Coverage ? 50.72%
=========================================
Files ? 111
Lines ? 17370
Branches ? 0
=========================================
Hits ? 8811
Misses ? 7468
Partials ? 1091 |
@Pennyzct your nightmare unfortunately 😿 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but I do think it would be extremely useful for tracking purposes to specify in the commit message why this bump was done (CVE's? features? magic flying unicorns 🦄? That kinda stuff 😄).
Hi @egernst plz bump the version to v4.19.84. It's the latest and will decrease the failed chunks. |
Fixes: kata-containers#2193 Depends-on: github.com/kata-containers/packaging#807 Signed-off-by: Eric Ernst <eric.ernst@intel.com>
/test |
@egernst CI does not seem to be very happy. |
@Pennyzct ^ still unhappy with patches. Sorry. |
we need to do patch update for kernel bump to v4.19.86. Fixes: kata-containers#806 Depends-on: github.com/kata-containers/runtime#2185 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
we need to do patch update for kernel bump to v4.19.86. Fixes: kata-containers#806 Depends-on: github.com/kata-containers/runtime#2185 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Hi @egernst |
/test |
As to the failure on ARM CI:
I've addressed related issue kata-containers/ci#229 to fix, and it should be irrelevant to this patch. ;). |
rerunning virtio-fs test. If it passes, we should be good to merge. |
we need to do patch update for kernel bump to v4.19.86. Fixes: kata-containers#806 Depends-on: github.com/kata-containers/runtime#2185 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Fixes: 1816
Signed-off-by: Eric Ernst eric.ernst@intel.com