Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

vc: Remove unnecessary call to kill #2216

Merged
merged 1 commit into from
Nov 19, 2019
Merged

vc: Remove unnecessary call to kill #2216

merged 1 commit into from
Nov 19, 2019

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Nov 19, 2019

Fixes #2207

Addresses https://github.com/kata-containers/runtime/pull/2204#issuecomment-555409722

Signed-off-by: Ted Yu <yuzhihong@gmail.com>

@tedyu
Copy link
Contributor Author

tedyu commented Nov 19, 2019

@jodh-intel
Please take a look.

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tedyu!

lgtm

@grahamwhaley
Copy link
Contributor

Hmm, Travis complaining about no SoB - can you see anything obvious @jodh-intel ?

ERROR: Commit 2950d87b6ab18f4ca1dfaac4a7bd628bd0bb761b: no Signed-off-by specified

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Fixes #2207

Signed-off-by: Ted Yu <yuzhihong@gmail.com>
@tedyu
Copy link
Contributor Author

tedyu commented Nov 19, 2019

@grahamwhaley
I removed the leading indentation for the sign off.

@grahamwhaley
Copy link
Contributor

/test

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c0d2867). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #2216   +/-   ##
=========================================
  Coverage          ?   49.24%           
=========================================
  Files             ?      111           
  Lines             ?    15828           
  Branches          ?        0           
=========================================
  Hits              ?     7794           
  Misses            ?     7069           
  Partials          ?      965

@tedyu
Copy link
Contributor Author

tedyu commented Nov 19, 2019

Test failure in kata-containers-runtime-ubuntu-18-04-PR-initrd doesn't seem to be related.

@tedyu
Copy link
Contributor Author

tedyu commented Nov 19, 2019

@grahamwhaley
Can this be merged ?

thanks

@grahamwhaley
Copy link
Contributor

@tedyu - heh, helps if you post the logs from the failed CI so we can see...:

Summarizing 5 Failures:

[Fail] [k8s.io] Container runtime should support basic operations on container [BeforeEach] runtime should support removing container [Conformance] 
/tmp/jenkins/workspace/kata-containers-runtime-ubuntu-18-04-PR-initrd/go/src/github.com/kubernetes-sigs/cri-tools/pkg/framework/util.go:214

[Fail] [k8s.io] Container runtime should support basic operations on container [BeforeEach] runtime should support starting container [Conformance] 
/tmp/jenkins/workspace/kata-containers-runtime-ubuntu-18-04-PR-initrd/go/src/github.com/kubernetes-sigs/cri-tools/pkg/framework/util.go:214

[Fail] [k8s.io] Container runtime should support basic operations on container [BeforeEach] runtime should support execSync [Conformance] 
/tmp/jenkins/workspace/kata-containers-runtime-ubuntu-18-04-PR-initrd/go/src/github.com/kubernetes-sigs/cri-tools/pkg/framework/util.go:214

[Fail] [k8s.io] Container runtime should support basic operations on container [BeforeEach] runtime should support stopping container [Conformance] 
/tmp/jenkins/workspace/kata-containers-runtime-ubuntu-18-04-PR-initrd/go/src/github.com/kubernetes-sigs/cri-tools/pkg/framework/util.go:214

[Fail] [k8s.io] Container runtime should support basic operations on container [BeforeEach] runtime should support creating container [Conformance] 
/tmp/jenkins/workspace/kata-containers-runtime-ubuntu-18-04-PR-initrd/go/src/github.com/kubernetes-sigs/cri-tools/pkg/framework/util.go:214

Ran 5 of 80 Specs in 28.791 seconds
FAIL! -- 0 Passed | 5 Failed | 0 Pending | 75 Skipped

and then, we normally re-fire the failed CI to check if it was sporadic or reproducible. Let me re-trigger that build on Jenkins...

@tedyu
Copy link
Contributor Author

tedyu commented Nov 19, 2019

@grahamwhaley
All tests passed.

@grahamwhaley
Copy link
Contributor

yay, so let's say sporadic fail... merging.

@grahamwhaley grahamwhaley merged commit 66f0ec5 into kata-containers:master Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants