vc: Sandbox#Annotations should use annotationsLock read lock

[tedyu]

Fixes #2222

Signed-off-by: Ted Yu yuzhihong@gmail.com

[tedyu]

@grahamwhaley
Can you review this ?

thanks

[grahamwhaley]

Hi @tedyu.
Sure.
I should probably explain some of the kata review process - we have a weekly rota of members watching out for new PRs and also processing and nudging along any stuck or stale PRs - so normally you should not have to nudge anybody to review - unless you happen to know who is a key owner of some code - in which case you can specifically ask them to review something.

I'm not the best person to review virtcontainers code, but will pull in the right folks who are.

thanks!

[tedyu]

Thanks @grahamwhaley for adding reviewers.

[tedyu]

@grahamwhaley @jodh-intel
Mind triggering test ?

Thanks

[grahamwhaley]

/test
sure thing!

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@66f0ec5). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2223   +/-   ##
=========================================
  Coverage          ?   49.05%           
=========================================
  Files             ?      111           
  Lines             ?    16058           
  Branches          ?        0           
=========================================
  Hits              ?     7878           
  Misses            ?     7206           
  Partials          ?      974

[tedyu]

15:07:43 panic: ERROR: Docker-like container engine not accessible to current user:  (error exec: "podman": executable file not found in $PATH)
15:07:43 
15:07:43 goroutine 1 [running, locked to thread]:
15:07:43 github.com/kata-containers/runtime/cli.init.1()
15:07:43 	/tmp/jenkins/workspace/kata-containers-runtime-fedora-PR/go/src/github.com/kata-containers/runtime/cli/main_test.go:105 +0x10c1
15:07:43 FAIL	github.com/kata-containers/runtime/cli	0.291s

The test failure didn't seem to be related.

@grahamwhaley
Can you re-trigger the fedora test ?

Thanks

[grahamwhaley]

done

[tedyu]

09:18:07 Stderr: failed to launch qemu: exit status 1, error messages from qemu log: qemu-system-x86_64: -object memory-backend-file,id=mem0,mem-path=/usr/share/kata-containers/kata-containers-clearlinux-31670-osbuilder-36a9dc5-agent-c87f497.img,size=118269440: backing store (null) size 0x70ca600 does not match 'size' option 0x70cb000

A different error this time.
I searched for the phrase which doesn't seem to be in kata-containers/runtime

@grahamwhaley
Can you trigger another test run ?

Thanks

[grahamwhaley]

I can. also /cc @chavafg to check if this is a known CI instability.

[chavafg]

@grahamwhaley haven't seen something similar, but will keep an eye to check if it happens again...

[tedyu]

@grahamwhaley
All tests passed.

FYI