Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

vc: Persist file handle may leak in FS#ToDisk #2242

Merged
merged 1 commit into from
Nov 22, 2019
Merged

vc: Persist file handle may leak in FS#ToDisk #2242

merged 1 commit into from
Nov 22, 2019

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Nov 21, 2019

Fixes #2241

Signed-off-by: Ted Yu yuzhihong@gmail.com

Fixes #2241

Signed-off-by: Ted Yu <yuzhihong@gmail.com>
Copy link

@devimc devimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tedyu

@devimc
Copy link

devimc commented Nov 21, 2019

/test-ubuntu

Copy link
Member

@egernst egernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks @tedyu

Was this found statically, or could you recreate this failure? Any tool?

@tedyu
Copy link
Contributor Author

tedyu commented Nov 21, 2019

This was not found via any tool.

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a17ca14). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #2242   +/-   ##
=========================================
  Coverage          ?   48.98%           
=========================================
  Files             ?      111           
  Lines             ?    16032           
  Branches          ?        0           
=========================================
  Hits              ?     7854           
  Misses            ?     7204           
  Partials          ?      974

@tedyu
Copy link
Contributor Author

tedyu commented Nov 22, 2019

@devimc @egernst
All tests passed.

@lifupan lifupan merged commit eae8449 into kata-containers:master Nov 22, 2019
@amshinde
Copy link
Member

amshinde commented Dec 2, 2019

Needs backport to stable branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist file handle may leak in FS#ToDisk
6 participants