This repository has been archived by the owner on May 12, 2021. It is now read-only.
vc: Drop Sandbox#Pause and Sandbox#Resume #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @bergwolf |
jodh-intel
reviewed
Nov 29, 2019
There was a problem hiding this comment.
Thanks for raising @tedyu but please update the tests. tal at Travis which is failing:
nstall virtcontainers
make: Entering directory '/home/travis/gopath/src/github.com/kata-containers/runtime/virtcontainers'
GOBUILD build
# github.com/kata-containers/runtime/virtcontainers
./api.go:66:2: cannot use s (type *Sandbox) as type VCSandbox in return argument:
*Sandbox does not implement VCSandbox (missing Pause method)
tedyu
force-pushed
the
rm-pause-resume
branch
from
a30b888 to
a90bb55
Compare
|
@jodh-intel |
tedyu
force-pushed
the
rm-pause-resume
branch
from
a90bb55 to
7ad930d
Compare
Fixes kata-containers#2276 Signed-off-by: Ted Yu <yuzhihong@gmail.com>
tedyu
force-pushed
the
rm-pause-resume
branch
from
7ad930d to
544730b
Compare
|
@grahamwhaley thanks |
Codecov Report
@@ Coverage Diff @@
## master #2283 +/- ##
=========================================
Coverage ? 48.71%
=========================================
Files ? 111
Lines ? 16029
Branches ? 0
=========================================
Hits ? 7809
Misses ? 7256
Partials ? 964 |
|
@bergwolf |
bergwolf
approved these changes
Dec 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2276
Signed-off-by: Ted Yu yuzhihong@gmail.com