Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

versions: Move to k8s 1.10 #278

Merged
merged 3 commits into from
May 11, 2018
Merged

Conversation

jcvenegas
Copy link
Member

Move to k8s 1.10

Fixes: #277

Signed-off-by: Jose Carlos Venegas Munoz jose.carlos.venegas.munoz@intel.com

Move to k8s 1.10

Fixes: kata-containers#277

Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
@chavafg
Copy link
Contributor

chavafg commented May 2, 2018

I was talking with the CRI-O guys and there will be compatibility issues between Openshift and Kubernetes, because latest Openshift v3.9 should use CRI-O 1.9 and k8s 1.10 should use CRI-O 1.10.

There isnt still an Openshift 3.10 out, neither an alpha release.

So I think we will need to have a way to test crio 1.9 with openshift v3.9.0 and crio 1.10 with k8s 1.10

@sboeuf
Copy link

sboeuf commented May 2, 2018

@chavafg thanks for the heads up. If we can fit this into our CI without increasing the time taken by the CI, that'd be great. I am saying that because the CI is already pretty slow (around an hour now...)
/cc @egernst

@chavafg
Copy link
Contributor

chavafg commented May 2, 2018

I was thinking Fedora to run Openshift tests and ubuntu to run k8s, what do you think @sboeuf @egernst @jcvenegas ?

@egernst
Copy link
Member

egernst commented May 2, 2018

@chavafg this makes a lot of sense to me - a natural division.

@sboeuf
Copy link

sboeuf commented May 2, 2018

👍

Approved with PullApprove

Update our supported openshift version
from v3.7.1 to v3.9.0

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
@jodh-intel
Copy link
Contributor

jodh-intel commented May 8, 2018

lgtm

Approved with PullApprove

1 similar comment
@amshinde
Copy link
Member

amshinde commented May 8, 2018

lgtm

Approved with PullApprove

@chavafg
Copy link
Contributor

chavafg commented May 8, 2018

Using k8s 1.10.0 kubeadm reset doesn't delete the pods created by CRI-O, while k8s 1.9 does it properly. Seems like an issue with cri-o or kuberentes, since I can reproduce the failure using runc. Still investigating...

@chavafg
Copy link
Contributor

chavafg commented May 8, 2018

The issue is already reported on kubeadm: kubernetes/kubeadm#748

I think the only option here is to add a workaround in the tests to delete the pods after running kubeadm reset using crictl and when this is fixed, remove the workaround.
cc @jcvenegas @egernst @sboeuf @amshinde @jodh-intel

@jodh-intel
Copy link
Contributor

Hi @chavafg - sounds reasonable to me.

Since we want to test under kubernetes 1.10 and we also
want to supoort latest version of Openshift, which is v3.9.0,
we need to test with with different versions of CRI-O.

K8s 1.10 should use cri-o 1.10, while openshift v3.9.0
should use v1.9

Depends-on: github.com/kata-containers/tests#277

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #278 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   64.53%   64.38%   -0.15%     
==========================================
  Files          86       86              
  Lines        8397     8432      +35     
==========================================
+ Hits         5419     5429      +10     
- Misses       2404     2428      +24     
- Partials      574      575       +1
Impacted Files Coverage Δ
virtcontainers/qemu.go 12.01% <0%> (-0.43%) ⬇️
virtcontainers/hyperstart_agent.go 58.58% <0%> (-0.18%) ⬇️
virtcontainers/kata_proxy.go 0% <0%> (ø) ⬆️
virtcontainers/kata_builtin_proxy.go 0% <0%> (ø) ⬆️
virtcontainers/kata_agent.go 29.3% <0%> (+0.02%) ⬆️
virtcontainers/utils/utils.go 71.6% <0%> (+3.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6544a3...5b9cebd. Read the comment docs.

@amshinde
Copy link
Member

amshinde commented May 9, 2018

@chavafg Yes, that sounds fine. Lets create an issue for it so we dont forget.

@chavafg
Copy link
Contributor

chavafg commented May 10, 2018

opened kata-containers/tests#296 to delete the workaround when the issue gets properly fixed.

@chavafg
Copy link
Contributor

chavafg commented May 10, 2018

This is ready to be merged, but please when merge this, please also merge this one in tests repository: kata-containers/tests#277

@jodh-intel jodh-intel merged commit 6227fa9 into kata-containers:master May 11, 2018
@jcvenegas jcvenegas deleted the k8s1.10 branch January 18, 2019 17:15
mcastelino pushed a commit to mcastelino/tests that referenced this pull request Jan 23, 2019
As we need CRI-O 1.9 to run tests on openshift v3.9.0 (latest)
and CRI-O 1.10 to run Kubernetes 1.10, we need to make a
division in our CI, so that we can test both scenarios without
adding more execution time to the CI jobs.
Because of this, we will execute CRI-O 1.9 - openshift v3.9.0
tests under Fedora and CRI-O 1.10 - Kubernetes 1.10 tests
under ubuntu.

Fixes: clearcontainers#276.

Depends-on: github.com/kata-containers/runtime#278

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
zklei pushed a commit to zklei/runtime that referenced this pull request Jun 13, 2019
Using random char generation at early boot may slow the process due to
low entropy.

Also from kernel 4.14.36 rand call hangs due to low-entropy. Lets
remove dependency on rand at early sandbox creation.

Fixes: kata-containers#278

Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants