Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

action: Require PR porting labels #2913

Merged

Conversation

jodh-intel
Copy link
Contributor

A PR now needs two labels to be applied before it can be merged. One
label must be a backport label from the list below and the other a
forward port label:

  • backport labels: needs-backport, no-backport-needed.
  • forward-port labels: needs-forward-port, no-forward-port-needed.

This is to make the maintainer think carefully before merging a PR and
hopefully maximise efficient porting.

Related: kata-containers/kata-containers#634

Fixes: #2912.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

@jodh-intel jodh-intel added the do-not-merge PR has problems or depends on another label Aug 28, 2020
@amshinde amshinde requested review from c3d and devimc September 9, 2020 23:11
@jodh-intel jodh-intel force-pushed the actions-require-pr-porting-labels branch 2 times, most recently from 7b9fc64 to 9895adb Compare September 10, 2020 10:20
@jodh-intel jodh-intel removed the do-not-merge PR has problems or depends on another label Sep 11, 2020
@jodh-intel
Copy link
Contributor Author

/test

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #2913 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2913   +/-   ##
=======================================
  Coverage   51.65%   51.65%           
=======================================
  Files         118      118           
  Lines       17430    17430           
=======================================
  Hits         9003     9003           
  Misses       7342     7342           
  Partials     1085     1085           

@jodh-intel
Copy link
Contributor Author

/test-metrics

A PR now needs *two* labels to be applied before it can be merged. One
label must be a backport label from the list below and the other a
forward port label:

- backport labels: `needs-backport`, `no-backport-needed`, `backport`.
- forward-port labels: `needs-forward-port`, `no-forward-port-needed`, `forward-port`.

This is to make the maintainer think carefully before merging a PR and
hopefully maximise efficient porting.

Related: kata-containers/kata-containers#634

Fixes: kata-containers#2912.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel jodh-intel force-pushed the actions-require-pr-porting-labels branch from 9895adb to 67be926 Compare September 14, 2020 14:29
@jodh-intel
Copy link
Contributor Author

/test

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@amshinde amshinde merged commit 9f233b1 into kata-containers:master Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

action: Require PR porting labels
3 participants