This repository has been archived by the owner on May 12, 2021. It is now read-only.
kata-check: check for newer release #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backport of kata-containers/kata-containers#735. |
|
/test |
jodh-intel
force-pushed
the
kata-check-compare-versions
branch
from
44c63dc to
eb47b77
Compare
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #2976 +/- ##
==========================================
- Coverage 51.65% 50.27% -1.38%
==========================================
Files 118 119 +1
Lines 17430 15758 -1672
==========================================
- Hits 9003 7923 -1080
+ Misses 7342 6753 -589
+ Partials 1085 1082 -3 |
Update `kata-check` to see if there is a newer version available for download. Useful for users installing static packages (without a package manager). Fixes: kata-containers#2975. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
kata-check-compare-versions
branch
from
eb47b77 to
a707608
Compare
jodh-intel
added a commit
to jodh-intel/kata-containers
that referenced
this pull request
Sep 23, 2020
Fix the linter errors caught in the `runtime` repos `master` branch [1], but not in the `2.0-dev` branch [2]. See [3] for further details. [1] - kata-containers/runtime#2976 [2] - kata-containers#735 [3] - kata-containers/tests#2870 Fixes: kata-containers#783. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
|
Ping @kata-containers/runtime ! |
@jodh-intel started looking at it.. .Thanks |
bpradipt
reviewed
Sep 24, 2020
| Name: "verbose, v", | ||
| Usage: "display the list of checks performed", | ||
| Name: "check-version-only", | ||
| Usage: "Only compare the current and latest available versions (requires network, non-root only)", |
There was a problem hiding this comment.
A minor nit.. It's not obvious from the description that it checks for release versions only. Although the subsequent options help with the clarification. Just noting down in case if it makes sense to make it more explicit.
bpradipt
approved these changes
Sep 24, 2020
|
Ping @kata-containers/runtime. This can land with one more qualifying ack (it's already landed in 2.x so really shouldn't take much time to review.... :) |
|
/test |
egernst
pushed a commit
to egernst/kata-containers
that referenced
this pull request
Oct 2, 2020
Fix the linter errors caught in the `runtime` repos `master` branch [1], but not in the `2.0-dev` branch [2]. See [3] for further details. [1] - kata-containers/runtime#2976 [2] - kata-containers#735 [3] - kata-containers/tests#2870 Fixes: kata-containers#783. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
egernst
pushed a commit
to kata-containers/kata-containers
that referenced
this pull request
Oct 7, 2020
Fix the linter errors caught in the `runtime` repos `master` branch [1], but not in the `2.0-dev` branch [2]. See [3] for further details. [1] - kata-containers/runtime#2976 [2] - #735 [3] - kata-containers/tests#2870 Fixes: #783. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
c3d
pushed a commit
to kata-containers/kata-containers
that referenced
this pull request
Apr 12, 2021
Fix the linter errors caught in the `runtime` repos `master` branch [1], but not in the `2.0-dev` branch [2]. See [3] for further details. [1] - kata-containers/runtime#2976 [2] - #735 [3] - kata-containers/tests#2870 Fixes: #783. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
c3d
pushed a commit
to c3d/kata-containers
that referenced
this pull request
Apr 12, 2021
Fix the linter errors caught in the `runtime` repos `master` branch [1], but not in the `2.0-dev` branch [2]. See [3] for further details. [1] - kata-containers/runtime#2976 [2] - kata-containers#735 [3] - kata-containers/tests#2870 Fixes: kata-containers#783. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
kata-checkto see if there is a newer version available for download. Useful for users installing static packages (without a package manager).Fixes: #2975.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com