This repository has been archived by the owner on May 12, 2021. It is now read-only.
version: add new docker version entry for agent test on arm #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongwu
added a commit
to jongwu/agent
that referenced
this pull request
Nov 11, 2020
"make proto" will fail on arm64 using docker 18.06. This bug will be gone if using docker 19.03. so upgrade docker before "make proto" for arm64. Depends-on: github.com/kata-containers/runtime#3057 Fixes: kata-containers#861 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
jongwu
added a commit
to jongwu/agent
that referenced
this pull request
Nov 11, 2020
"make proto" will fail on arm64 using docker 18.06. This bug will be gone if using docker 19.03. so upgrade docker before "make proto" for arm64. Depends-on: github.com/kata-containers/runtime#3057 Fixes: kata-containers#861 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
jongwu
added a commit
to jongwu/agent
that referenced
this pull request
Nov 11, 2020
"make proto" will fail on arm64 using docker 18.06. This bug will be gone if using docker 19.03. so upgrade docker before "make proto" for arm64. Depends-on: github.com/kata-containers/runtime#3057 Fixes: kata-containers#861 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
|
thanks @jongwu , but |
|
lgtm |
make proto in agent test on arm64 will fail when using docker 18.06 and using docker 19.03 can avoid that failure. So a new entry of docker version for agent on arm64 is added. Signed-off-by: Jianyong wu <jianyong.wu@arm.com> Fixes: kata-containers#3056
jongwu
added a commit
to jongwu/agent
that referenced
this pull request
Nov 12, 2020
"make proto" will fail on arm64 using docker 18.06. This bug will be gone if using docker 19.03. so upgrade docker before "make proto" for arm64. Depends-on: github.com/kata-containers/runtime#3057 Fixes: kata-containers#861 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
jongwu
added a commit
to jongwu/agent
that referenced
this pull request
Nov 17, 2020
"make proto" will fail on arm64 using docker 18.06. This bug will be gone if using docker 19.03. so upgrade docker before "make proto" for arm64. Depends-on: github.com/kata-containers/runtime#3057 Fixes: kata-containers#861 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
jongwu
added a commit
to jongwu/agent
that referenced
this pull request
Nov 17, 2020
"make proto" will fail on arm64 using docker 18.06. This bug will be gone if using docker 19.03. so upgrade docker before "make proto" for arm64. Depends-on: github.com/kata-containers/runtime#3057 Fixes: kata-containers#861 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #3057 +/- ##
==========================================
+ Coverage 50.28% 50.44% +0.16%
==========================================
Files 120 120
Lines 15841 15917 +76
==========================================
+ Hits 7966 8030 +64
- Misses 6789 6796 +7
- Partials 1086 1091 +5 |
|
Hello @jodh-intel @lifupan, any comments? |
lifupan
approved these changes
Nov 24, 2020
|
hello @jodh-intel @devimc , is it time to merge this PR? |
devimc
approved these changes
Nov 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make proto in agent test on arm64 will fail when using docker 18.06
and using docker 19.03 can avoid that failure. So a new entry of
docker version for agent on arm64 is added.
Signed-off-by: Jianyong wu jianyong.wu@arm.com
Fixes: #3056
@jodh-intel @devimc