This repository has been archived by the owner on May 12, 2021. It is now read-only.
cli: make check subcommand more tolerant to failures #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amshinde
reviewed
Nov 20, 2020
devimc
force-pushed
the
2020-11-19/fixKataCheck
branch
from
6b312a6 to
901eb01
Compare
|
@amshinde change applied, thanks |
jodh-intel
approved these changes
Nov 20, 2020
devimc
force-pushed
the
2020-11-19/fixKataCheck
branch
from
901eb01 to
dd1e867
Compare
|
@jodh-intel changes applied, thanks /test |
Don't fail if rate limit is exceeded since this is a limitation/restriction of Github not a problem in the host. Print a warning when the rate limit is exceeded. For more information about Github's rate limit, see https://developer.github.com/v3/#rate-limiting Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc
force-pushed
the
2020-11-19/fixKataCheck
branch
from
dd1e867 to
aa26753
Compare
|
/test |
Before loading a module, the check subcommand should check if the current user can load it. fixes kata-containers#3085 Signed-off-by: Julio Montes <julio.montes@intel.com>
devimc
force-pushed
the
2020-11-19/fixKataCheck
branch
from
aa26753 to
c963777
Compare
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #3086 +/- ##
==========================================
- Coverage 50.42% 50.37% -0.06%
==========================================
Files 120 120
Lines 15910 15923 +13
==========================================
- Hits 8023 8021 -2
- Misses 6796 6812 +16
+ Partials 1091 1090 -1 |
GabyCT
approved these changes
Nov 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.