test: supplement test cases for kata-check and kata-env in Arm64 #414
Conversation
|
ptal😊. @bergwolf @jodh-intel |
|
PSS Measurement: Memory inside container: |
| @@ -455,3 +456,72 @@ func TestKvmIsUsable(t *testing.T) { | |||
| err = kvmIsUsable() | |||
| assert.Error(err) | |||
| } | |||
|
|
|||
| func TestGetCPUDetails(t *testing.T) { | |||
There was a problem hiding this comment.
This test function is identical for amd64 and ppc64le. So, I suggest you move this function to cli/kata-check_test.go and call it func genericTestGetCPUDetails(t *testing).
Then, you can update cli/kata-check_amd64_test.go and cli/kata-check_ppc64le_test.go to have just:
func TestGetCPUDetails(t *testing.T) {
genericTestGetCPUDetails(t)
}
|
@nitkon - since this touches ppc64le code, please could you review/test the changes? |
|
CI failed with |
|
@bergwolf license identifier has already been updated.🙂 |
|
PSS Measurement: Memory inside container: |
|
lgtm. CI is failing on linter errors - kata-containers/tests#439. |
There were missing test cases in Arm64 for platform-dependent kata-check and kata-env, leading to 'make test' failure under kata-containers/runtime Fixes: kata-containers#403 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
|
PSS Measurement: Memory inside container: |
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
=========================================
Coverage ? 63.99%
=========================================
Files ? 87
Lines ? 8795
Branches ? 0
=========================================
Hits ? 5628
Misses ? 2563
Partials ? 604Continue to review full report at Codecov.
|
|
@sboeuf Hi~thanks for approving. I have already fixed linter warning😊 and passed CI. |
|
Hi @nitkon - I haven't heard back so I assume you are ok with these changes. If not, please raise a follow-on PR. lgtm |
cgroup: fix the issue of crashed when meet unsupported cgroup
There were missing test cases in Arm64 for platform-dependent kata-check and kata-env, leading to 'make test' failure under kata-containers/runtime
Fixes: #403
Signed-off-by: Penny Zheng penny.zheng@arm.com