This repository has been archived by the owner on May 12, 2021. It is now read-only.
qemu: Pass sandboxID to agent for logging purposes #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a kernel command-line option that the agent can read to determine the sandbox ID of the VM. It can use this to create a `sandbox=` log field for improved log analysis. Fixes kata-containers#465. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
|
Related: #463. |
grahamwhaley
approved these changes
Jul 4, 2018
|
The other half of this feature is: kata-containers/agent#292. |
This was referenced Jul 4, 2018
|
PSS Measurement: Memory inside container: |
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
==========================================
- Coverage 64.24% 64.23% -0.01%
==========================================
Files 87 87
Lines 8837 8838 +1
==========================================
Hits 5677 5677
- Misses 2554 2555 +1
Partials 606 606
Continue to review full report at Codecov.
|
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a kernel command-line option that the agent can read to determine
the sandbox ID of the VM. It can use this to create a
sandbox=logfield for improved log analysis.
Fixes #465.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com