This repository has been archived by the owner on May 12, 2021. It is now read-only.
devices: add per-device VFIO ids #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds per-device VFIO ids allowing IOMMU groups with multiple devices to be passed to qemu. Fixes kata-containers#708 Signed-off-by: Edward Guzman <eguzman@nvidia.com>
|
PSS Measurement: Memory inside container: |
|
Build failed (third-party-check pipeline) integration testing with
|
Codecov Report
@@ Coverage Diff @@
## stable-1.2 #721 +/- ##
===========================================
Coverage 66.89% 66.89%
===========================================
Files 85 85
Lines 9161 9161
===========================================
Hits 6128 6128
Misses 2394 2394
Partials 639 639 |
|
LGTM |
sboeuf
approved these changes
Sep 13, 2018
|
LGTM |
|
Is this needed in |
It looks like this bug was introduced after |
|
Yes this was introduced as part of the whole device model rework, which was introduced in 1.2. |
egernst
pushed a commit
to egernst/runtime
that referenced
this pull request
Feb 9, 2021
Do not ignore ipv6 addresses and routes. These are not processes along with ipv4 routes. Add tests to verify ipv6 addresses and routes are processed with `updateRoutes`. Fixes kata-containers#721 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: #715
Adds per-device VFIO ids allowing IOMMU groups with
multiple devices to be passed to qemu.
Fixes #708
Signed-off-by: Edward Guzman eguzman@nvidia.com