Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

metrics: report: elasticsearch density: scripts fail to find results #1095

Closed
grahamwhaley opened this issue Jan 28, 2019 · 0 comments
Closed

Comments

@grahamwhaley
Copy link
Contributor

the metrics report is failing to pick up the elastic search density results, because when we pinned the elasticsearch version, that changed the name format of the results file (that now includes the pinned version of the container under test):

$ ls results/*elastic*
results/footprint-elasticsearch:6.4.0-ksm.json

but the script only looks for a vanilla footprint-elasticsearch[-ksm].json.

We have a few options to fix this:

Although I'd quite like to not have versions in the results file names, having them there does make it clear we pinned the image. I'd probably opt to fix the R search routine to cater for wildcard matching. Up for debate though if somebody wants.

grahamwhaley pushed a commit to grahamwhaley/kata-containers-tests that referenced this issue Apr 10, 2019
The footprint density report script did not know how to handle the
container version turning up in the results (which happens if we
pin a container rather than use 'latest', as we do with elastic).

Add wildcard file searching and the appropriate de-nesting of data
to the script to find and use all 'XXX.*\.json' results files it
finds for each container name.

Fixes: kata-containers#1095

Signed-off-by: Graham Whaley <graham.whaley@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant