This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
ci: baremetal cleanup: scripts should not fail if there are things they cannot cleanup #913
Comments
grahamwhaley
pushed a commit
to grahamwhaley/kata-containers-tests
that referenced
this issue
Nov 19, 2018
The cleanup scripts failed if any sub-part of the cleanup failed. This then trickled out to the CI system, which would fail the build. We should probably never fail the cleanup process, even if sub-parts of the cleanup faii, as the system we are trying to clean may be in an unstable state - that is the point of trying to clean it. Drop the `-e` from the top level clean call, and `|| true` the sub-func call for added measure. Fixes: kata-containers#913 Signed-off-by: Graham Whaley <graham.whaley@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The baremetal cleanup scripts are called by the jenkins script before we do a PR build - but, probably almost no matter what, that script should not fail, even if it thinks it cannot clean up.
Right now, if you don't have
dockerinstalled, the script fails, and we drop out of the jenkins script before it's even built the PR. Let's fix that...Related #868
The text was updated successfully, but these errors were encountered: