This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
metrics: launch times: update end check for new kernel dmesg #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kernel dmesg output has changed around the 'Freeing kernel memory', which we search for to try and identify the 'end of kernel' boot time. Update the search expression we use to find the last instance of these lines - which was as easy as trimming the 'memory' word from the end of the expression, which now works for both older and newer kernel demsg outputs. As an example of how the outputs changed, here is a grep of two logs (taken from bare metal hosts btw, not Kata Container boots): $ grep "Freeing unused kernel" *log newlog:[ 2.243048] Freeing unused kernel image memory: 2180K newlog:[ 2.248191] Freeing unused kernel image memory: 2012K newlog:[ 2.248337] Freeing unused kernel image memory: 120K oldlog:[ 2.462519] Freeing unused kernel memory: 1528K oldlog:[ 2.483732] Freeing unused kernel memory: 1664K oldlog:[ 2.484299] Freeing unused kernel memory: 92K Fixes: kata-containers#1036 Signed-off-by: Graham Whaley <graham.whaley@intel.com>
|
lgtm! /test |
|
lgtm |
|
we have enough LGTM, and travis is only failing on macOS, let's merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel dmesg output has changed around the 'Freeing kernel memory',
which we search for to try and identify the 'end of kernel' boot time.
Update the search expression we use to find the last instance of these
lines - which was as easy as trimming the 'memory' word from the end
of the expression, which now works for both older and newer kernel
demsg outputs.
As an example of how the outputs changed, here is a grep of two logs
(taken from bare metal hosts btw, not Kata Container boots):
$ grep "Freeing unused kernel" *log
newlog:[ 2.243048] Freeing unused kernel image memory: 2180K
newlog:[ 2.248191] Freeing unused kernel image memory: 2012K
newlog:[ 2.248337] Freeing unused kernel image memory: 120K
oldlog:[ 2.462519] Freeing unused kernel memory: 1528K
oldlog:[ 2.483732] Freeing unused kernel memory: 1664K
oldlog:[ 2.484299] Freeing unused kernel memory: 92K
Fixes: #1036
Signed-off-by: Graham Whaley graham.whaley@intel.com