ci: Modify Firecracker to install from repository #1092
Conversation
Instead of installing firecracker, runtime, and all the other Kata components from the tar, this will change to install from the sources. Fixes kata-containers#1091 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
|
@chavafg changes applied |
|
/test |
|
/test |
| # Checkout to specific version | ||
| pushd "${GOPATH}/src/${firecracker_repo}" | ||
| git checkout tags/${firecracker_version} | ||
| ./tools/devtool --unattended build --release -- --features vsock |
There was a problem hiding this comment.
good, I had the idea you'd reuse the script on https://github.com/kata-containers/packaging/blob/master/static-build/firecracker/build-static-firecracker.sh to not duplicated code, but if this wont change a lot lets keep in this way.
@mcastelino @jodh-intel any precerence here?
| # Checkout to specific version | ||
| pushd "${GOPATH}/src/${firecracker_repo}" | ||
| git checkout tags/${firecracker_version} | ||
| ./tools/devtool --unattended build --release -- --features vsock |
There was a problem hiding this comment.
good, I had the idea you'd reuse the script on https://github.com/kata-containers/packaging/blob/master/static-build/firecracker/build-static-firecracker.sh to not duplicated code, but if this wont change a lot lets keep in this way.
@mcastelino @jodh-intel any precerence here?
There was a problem hiding this comment.
@jcvenegas I am ok with a little duplication as long the right version gets picked up. I am planning to update to the latest version today or next week (to 0.14)
|
@grahamwhaley , |
|
haha - I just opened kata-containers/ci#102 |
| docker_options="-D --add-runtime kata-runtime=/usr/local/bin/kata-runtime" | ||
| echo "Add kata-runtime as a new/default Docker runtime." | ||
| "${cidir}/../cmd/container-manager/manage_ctr_mgr.sh" docker configure -r kata-runtime -f | ||
| if [ "$KATA_HYPERVISOR" == "qemu" ]; then |
There was a problem hiding this comment.
@GabyCT looks like we made it either or. Can we support both at the same time, potentially one of them via a shell script. I will work on eliminating the shell script based on
kata-containers/runtime#1082
Till then can we route fc through a shell script
There was a problem hiding this comment.
@mcastelino , this script is mainly to enable a Jenkins job for Firecracker. I can not install qemu and firecracker at the same time in the jenkins job mainly because not all the tests are passing in firecracker and also we want to keep them separate so the job does not take a lot of time to run.
There was a problem hiding this comment.
@GabyCT then I am fine. I assumed this was the actual install script
| # Checkout to specific version | ||
| pushd "${GOPATH}/src/${firecracker_repo}" | ||
| git checkout tags/${firecracker_version} | ||
| ./tools/devtool --unattended build --release -- --features vsock |
There was a problem hiding this comment.
@jcvenegas I am ok with a little duplication as long the right version gets picked up. I am planning to update to the latest version today or next week (to 0.14)
Instead of installing firecracker, runtime, and all the other Kata
components from the tar, this will change to install from the sources.
Fixes #1091
Signed-off-by: Gabriela Cervantes gabriela.cervantes.tellez@intel.com