-
Notifications
You must be signed in to change notification settings - Fork 195
Fix crio execsync issue #2171
Fix crio execsync issue #2171
Conversation
CI today does not use conmon version specified in version.yaml, instead builds from master. The latest version of conmon seemed to have changed certain exit codes for exec and introduced errors described in kata-containers/runtime#2352 Have the CI checkout version from versions.yaml and build conmon. Fixes kata-containers#2170 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
53cfde2
to
8be9593
Compare
/test |
Missing format for CI in |
@jcvenegas Thanks, just updated :) |
This reverts commit 667a242. Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
8be9593
to
c27425e
Compare
/test |
Looking at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @amshinde!
lgtm
If you want to update this PR to add in the missing checkouts as @bergwolf pointed out, that would be great but we could always handle that on a separate PR.
<random_thought>
Since the versions database is queried through .ci/lib.sh:get_version()
I wonder how easy it would be to make that function cleverer so that .ci/teardown.sh
could determine if all versions in the database had been "consumed" (in other words that get_version()
had been called for every entry in the versions database which would ensure we don't need to raise PRs like this)? If not, the test could be failed. I suspect that might be harder than it sounds though 😄
</random_thought>
@jodh-intel @bergwolf I'll handle the rest of the checkouts in a separate PR. |
CI today does not use conmon version specified in
version.yaml, instead builds from master.
The latest version of conmon seemed to have changed certain
exit codes for exec and introduced errors described in
kata-containers/runtime#2352
Have the CI checkout version from versions.yaml and build conmon.
Fixes #2170