Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Fix crio execsync issue #2171

Merged
merged 2 commits into from
Dec 16, 2019

Conversation

amshinde
Copy link
Member

@amshinde amshinde commented Dec 13, 2019

CI today does not use conmon version specified in
version.yaml, instead builds from master.
The latest version of conmon seemed to have changed certain
exit codes for exec and introduced errors described in
kata-containers/runtime#2352

Have the CI checkout version from versions.yaml and build conmon.

Fixes #2170

CI today does not use conmon version specified in
version.yaml, instead builds from master.
The latest version of conmon seemed to have changed certain
exit codes for exec and introduced errors described in
kata-containers/runtime#2352

Have the CI checkout version from versions.yaml and build conmon.

Fixes kata-containers#2170

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
@amshinde amshinde force-pushed the fix-crio-execsync-issue branch from 53cfde2 to 8be9593 Compare December 13, 2019 22:37
@amshinde
Copy link
Member Author

/test

@jcvenegas
Copy link
Member

Missing format for CI in This reverts commit 667a242.

@amshinde
Copy link
Member Author

@jcvenegas Thanks, just updated :)

This reverts commit 667a242.

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
@amshinde amshinde force-pushed the fix-crio-execsync-issue branch from 8be9593 to c27425e Compare December 13, 2019 22:44
@amshinde
Copy link
Member Author

/test

@amshinde amshinde requested a review from chavafg December 13, 2019 22:58
@bergwolf
Copy link
Member

Looking at .ci/install_*.sh by git grep "go get -d ", it seems we have several other places where we are fetching and building the master version of dependency softwares. Should we fix them as well?

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @amshinde!

lgtm

If you want to update this PR to add in the missing checkouts as @bergwolf pointed out, that would be great but we could always handle that on a separate PR.

<random_thought>
Since the versions database is queried through .ci/lib.sh:get_version() I wonder how easy it would be to make that function cleverer so that .ci/teardown.sh could determine if all versions in the database had been "consumed" (in other words that get_version() had been called for every entry in the versions database which would ensure we don't need to raise PRs like this)? If not, the test could be failed. I suspect that might be harder than it sounds though 😄
</random_thought>

@amshinde
Copy link
Member Author

@jodh-intel @bergwolf I'll handle the rest of the checkouts in a separate PR.
@jodh-intel Thanks for the suggestion, let me see if we can add that check .

@amshinde amshinde merged commit c064880 into kata-containers:master Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cri-o execsync test is failing in CI
6 participants