This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
[1.10 backport]: cri-o: Check out specific version of conmon in CI #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI today does not use conmon version specified in version.yaml, instead builds from master. The latest version of conmon seemed to have changed certain exit codes for exec and introduced errors described in kata-containers/runtime#2352 Have the CI checkout version from versions.yaml and build conmon. Fixes kata-containers#2170 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
jcvenegas
approved these changes
Jan 9, 2020
|
/test-ubuntu |
GabyCT
approved these changes
Jan 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI today does not use conmon version specified in
version.yaml, instead builds from master.
The latest version of conmon seemed to have changed certain
exit codes for exec and introduced errors described in
kata-containers/runtime#2352
Have the CI checkout version from versions.yaml and build conmon.
backport of b145f4c
Fixes #2170
Signed-off-by: Archana Shinde archana.m.shinde@intel.com