-
Notifications
You must be signed in to change notification settings - Fork 196
Conversation
ae3d9fe
to
72a0c3f
Compare
90314a9
to
075241c
Compare
e243bb7
to
0d0f3ad
Compare
54312d7
to
6adac0d
Compare
integration/openshift/teardown.sh
Outdated
source "${SCRIPT_PATH}/openshiftrc" | ||
|
||
echo "Terminate Openshift master and node processes" | ||
pgrep openshift | xargs sudo kill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be kill -9
... ?
integration/openshift/teardown.sh
Outdated
# Workaround: | ||
# Currently deleting a pod using 'oc delete pod' is failing. | ||
# See: https://github.com/kata-containers/runtime/issues/197 | ||
sudo rm -rf /var/lib/containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if umount is needed before removing directories
marking as DNM until we solve the pod delete issue: kata-containers/runtime#197 |
Makefile
Outdated
|
||
check: checkcommits log-parser | ||
|
||
.PHONY: check checkcommits integration ginkgo log-parser test crio functional docker-compose kubernetes | ||
.PHONY: \ | ||
check \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the reformatting here, but could you sort it alphabetically? 😄
@chavafg this kata-containers/runtime#232 should solve the issue, would be nice if you could confirm. |
6adac0d
to
1395513
Compare
d36f5db
to
6a73bc5
Compare
This change adds openshift installation into the CI process and executes a simple test that verifies connectivity between an openshift pod and the host. Fixes: kata-containers#220. Depends-on: github.com/kata-containers/runtime#232 Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
6a73bc5
to
e4cbe48
Compare
now that now that kata-containers/runtime#232 is merged, this can land. |
@chavafg please give a try for k8s with kata-containers/agent#225, it works :) |
@sboeuf yes, it worked perfectly deleting pods using kubectl. Still having issues when running kubeadm reset, but I think that will be hanled in different patch, right? |
@chavafg cool, thanks for checking ! |
@devimc @GabyCT @jodh-intel PTAL |
This change adds openshift installation into the CI process
and executes a simple test that verifies connectivity between
an openshift pod and the host.
Fixes: #220.
Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com