Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

tests: Add initial openshift testing #221

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

chavafg
Copy link
Contributor

@chavafg chavafg commented Apr 5, 2018

This change adds openshift installation into the CI process
and executes a simple test that verifies connectivity between
an openshift pod and the host.

Fixes: #220.

Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com

@chavafg chavafg added the review label Apr 5, 2018
@chavafg chavafg force-pushed the topic/openshift branch 4 times, most recently from ae3d9fe to 72a0c3f Compare April 6, 2018 13:24
@chavafg chavafg force-pushed the topic/openshift branch 2 times, most recently from 90314a9 to 075241c Compare April 6, 2018 19:35
@chavafg chavafg added the wip label Apr 6, 2018
@chavafg chavafg force-pushed the topic/openshift branch 11 times, most recently from e243bb7 to 0d0f3ad Compare April 11, 2018 12:35
@chavafg chavafg removed the wip label Apr 11, 2018
@chavafg chavafg force-pushed the topic/openshift branch 2 times, most recently from 54312d7 to 6adac0d Compare April 11, 2018 18:58
source "${SCRIPT_PATH}/openshiftrc"

echo "Terminate Openshift master and node processes"
pgrep openshift | xargs sudo kill
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be kill -9 ... ?

# Workaround:
# Currently deleting a pod using 'oc delete pod' is failing.
# See: https://github.com/kata-containers/runtime/issues/197
sudo rm -rf /var/lib/containers
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if umount is needed before removing directories

@chavafg
Copy link
Contributor Author

chavafg commented Apr 13, 2018

marking as DNM until we solve the pod delete issue: kata-containers/runtime#197

Makefile Outdated

check: checkcommits log-parser

.PHONY: check checkcommits integration ginkgo log-parser test crio functional docker-compose kubernetes
.PHONY: \
check \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the reformatting here, but could you sort it alphabetically? 😄

@sboeuf
Copy link

sboeuf commented Apr 19, 2018

@chavafg this kata-containers/runtime#232 should solve the issue, would be nice if you could confirm.

@chavafg chavafg force-pushed the topic/openshift branch 4 times, most recently from d36f5db to 6a73bc5 Compare April 26, 2018 15:18
This change adds openshift installation into the CI process
and executes a simple test that verifies connectivity between
an openshift pod and the host.

Fixes: kata-containers#220.

Depends-on: github.com/kata-containers/runtime#232

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
@chavafg
Copy link
Contributor Author

chavafg commented Apr 26, 2018

now that now that kata-containers/runtime#232 is merged, this can land.

@sboeuf
Copy link

sboeuf commented Apr 26, 2018

@chavafg please give a try for k8s with kata-containers/agent#225, it works :)

@chavafg
Copy link
Contributor Author

chavafg commented Apr 27, 2018

@sboeuf yes, it worked perfectly deleting pods using kubectl.

Still having issues when running kubeadm reset, but I think that will be hanled in different patch, right?

@sboeuf
Copy link

sboeuf commented Apr 27, 2018

@chavafg cool, thanks for checking !
Yes the isssue with kubeadm reset is a separate issue and I am currently investigating this.

@chavafg
Copy link
Contributor Author

chavafg commented Apr 27, 2018

@devimc @GabyCT @jodh-intel PTAL

@GabyCT
Copy link
Contributor

GabyCT commented Apr 27, 2018

lgtm

Approved with PullApprove

@devimc devimc merged commit 94ced14 into kata-containers:master Apr 27, 2018
@chavafg chavafg deleted the topic/openshift branch May 31, 2018 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants