This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 195
cmd/log-parser: Add containerID and sandboxID to standard log entry #465
Merged
chavafg
merged 3 commits into
kata-containers:master
from
jodh-intel:add-cid-to-log-parser
Jul 4, 2018
Merged
cmd/log-parser: Add containerID and sandboxID to standard log entry #465
chavafg
merged 3 commits into
kata-containers:master
from
jodh-intel:add-cid-to-log-parser
Jul 4, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamwhaley
approved these changes
Jul 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hopefully I'll get to try this soon as well.
some CI errors:
|
jodh-intel
force-pushed
the
add-cid-to-log-parser
branch
from
July 3, 2018 11:59
a997792
to
68891a3
Compare
Branch updated. |
Enhance some of the errors that are returned to make locating the issue in the log file easier. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Extract the container ID from the structured logs and add it to the standard `LogEntry` type. This will allow (most of) the log entries to be associated with individual containers, which will make debugging and analysis easier. Fixes kata-containers#453. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
add-cid-to-log-parser
branch
from
July 4, 2018 13:15
68891a3
to
1255a4d
Compare
Branch updated to resolve merge conflict. |
jodh-intel
changed the title
cmd/log-parser: Add containerID to standard log entry
cmd/log-parser: Add containerID and sandboxID to standard log entry
Jul 4, 2018
Extract the sandbox ID from the structured logs and add it to the standard `LogEntry` type. This will allow (most of) the log entries to be associated with sandboxes, which will make debugging and analysis easier. Fixes kata-containers#474. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
add-cid-to-log-parser
branch
from
July 4, 2018 14:38
08c38e1
to
f329acf
Compare
Branch updated to also pick out the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the container ID from the structured logs and add it to the
standard
LogEntry
type. This will allow (most of) the log entries tobe associated with individual containers, which will make debugging and
analysis easier.
Also, enhance some of the errors that are returned to make locating the issue
in the log file easier.
Fixes #453.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com