Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

ci: support install_qemu in aarch64 #487

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Conversation

Pennyzct
Copy link
Contributor

for now, default hypervisor would be qemu instead of qemu-lite in aarch64. packaged qemu has only be supproted in fedora and ubuntu for aarch64.

Fixes: #472

Signed-off-by: Penny Zheng penny.zheng@arm.com
Signed-off-by: Jianyong Wu jianyong.wu@arm.com

for now, default hypervisor would be qemu instead of qemu-lite in
aarch64. packaged qemu has only be supproted in fedora and ubuntu
for aarch64.

Fixes: kata-containers#472

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
@Pennyzct
Copy link
Contributor Author

relevant pr in kata-containers/packaging: #94

Copy link
Contributor

@chavafg chavafg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

you'll need to make modifications in the kata-runtime configuration file to point to qemu-system-x86_64 instead of qemu-lite-system-x86_64, maybe you already have that in mind for another PR?

also, in other PRs we could group the lib scripts that are specific for aarch64 in a sub-directory of .ci/

@Pennyzct
Copy link
Contributor Author

Hi, @chavafg ~ if you mean what's in /usr/share/defaults/kata-containers/configuration.toml, the default for non-x86 arch would already be qemu, not qemu-lite😀. and it will be great for having a sub-directory to store arm64-specific lib files.

@chavafg
Copy link
Contributor

chavafg commented Jul 11, 2018

ohh great, yes, I was referring to that file, didn't know that qemu was the default there. Thanks.
Lets just wait for another ack and we can merge this one.

@GabyCT
Copy link
Contributor

GabyCT commented Jul 11, 2018

lgtm

Approved with PullApprove

@GabyCT GabyCT merged commit 4807ae1 into kata-containers:master Jul 11, 2018
Pennyzct added a commit to Pennyzct/tests that referenced this pull request Aug 9, 2018
Based on upstream discussion kata-containers#514 and kata-containers#487, we move all aarch64-specif lib
files under aarch64/ dir, only leaving default options in main .ci/
dir.

Fixes: kata-containers#593

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
chavafg pushed a commit to chavafg/tests-1 that referenced this pull request Nov 12, 2018
Based on upstream discussion kata-containers#514 and kata-containers#487, we move all aarch64-specif lib
files under aarch64/ dir, only leaving default options in main .ci/
dir.

Fixes: kata-containers#593

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants