This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
ci: Static checks for license should ignore any *.pb.go file #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All *.pb.go files are generated files from *.proto files. There is no reason to ignore only the ones from protocols/grpc subdirectory. Fixes kata-containers#851 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
|
/test |
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this pull request
Oct 24, 2018
Some structures such as Interface and Route are not only used by the kata-agent since they are generic enough to be reused by kata-runtime or kata-netmon. By splitting those structures into their separate package, we prevent their consumers from importing the whole protocols/grpc package which pulls a lot of unneeded content. Depends-on: github.com/kata-containers/tests#852 Fixes kata-containers#399 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
|
lgtm |
1 similar comment
|
lgtm |
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this pull request
Oct 24, 2018
Some structures such as Interface and Route are not only used by the kata-agent since they are generic enough to be reused by kata-runtime or kata-netmon. By splitting those structures into their separate package, we prevent their consumers from importing the whole protocols/grpc package which pulls a lot of unneeded content. Depends-on: github.com/kata-containers/tests#852 Fixes kata-containers#399 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this pull request
Oct 24, 2018
Some structures such as Interface and Route are not only used by the kata-agent since they are generic enough to be reused by kata-runtime or kata-netmon. By splitting those structures into their separate package, we prevent their consumers from importing the whole protocols/grpc package which pulls a lot of unneeded content. Depends-on: github.com/kata-containers/tests#852 Fixes kata-containers#399 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All *.pb.go files are generated files from *.proto files. There is no
reason to ignore only the ones from protocols/grpc subdirectory.
Fixes #851
Signed-off-by: Sebastien Boeuf sebastien.boeuf@intel.com