vc: Persist file handle may leak in FS#FromDisk

Fixes kata-containers#2233 Signed-off-by: Ted Yu <yuzhihong@gmail.com>
katabuilder · Nov 20, 2019 · 2331e87 · 2331e87
1 parent 1f71114
commit 2331e87
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/virtcontainers/persist/fs/fs.go b/virtcontainers/persist/fs/fs.go
@@ -201,11 +201,11 @@ func (fs *FS) FromDisk(sid string) (persistapi.SandboxState, map[string]persista
 			return ss, nil, err
 		}
 
+		defer cf.Close()
 		var cstate persistapi.ContainerState
 		if err := json.NewDecoder(cf).Decode(&cstate); err != nil {
 			return ss, nil, err
 		}
-		cf.Close()
 
 		fs.containerState[cid] = cstate
 	}