-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support 9.3.0 without Cucumber vulnerabilities #163
base: master
Are you sure you want to change the base?
Changes from all commits
a7969eb
971a7ff
73c3d48
2efaddf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,9 +37,18 @@ apt -y install fonts-liberation | |
apt -y install fonts-ipafont-gothic | ||
apt -y install fonts-wqy-zenhei | ||
apt -y install fonts-tlwg-loma-otf | ||
apt -y install ttf-ubuntu-font-family | ||
apt -y install fonts-ubuntu | ||
|
||
echo "Install Mozilla Firefox" | ||
install -d -m 0755 /etc/apt/keyrings | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you explain these code? without it, the docker still download correct Firefox version There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This might only be relevant with later Ubuntu versions, but in those later versions, apt no longer actually installs Firefox. The change is described here: |
||
wget -q https://packages.mozilla.org/apt/repo-signing-key.gpg -O- | tee /etc/apt/keyrings/packages.mozilla.org.asc > /dev/null | ||
echo "deb [signed-by=/etc/apt/keyrings/packages.mozilla.org.asc] https://packages.mozilla.org/apt mozilla main" | tee -a /etc/apt/sources.list.d/mozilla.list > /dev/null | ||
echo ' | ||
Package: * | ||
Pin: origin packages.mozilla.org | ||
Pin-Priority: 1000 | ||
' | tee /etc/apt/preferences.d/mozilla | ||
apt update | ||
apt -y install firefox | ||
# Install 'pulseaudio' package to support WebRTC audio streams | ||
apt -y install pulseaudio | ||
|
@@ -64,7 +73,7 @@ echo "$(microsoft-edge --version)" >> $KATALON_VERSION_FILE || true | |
./wrap_edge_chromium_binary.sh && rm -rfv ./wrap_edge_chromium_binary.sh | ||
|
||
echo "Install Gradle" | ||
gradle_version='5.4.1' | ||
gradle_version='7.6.4' | ||
gradle_package="gradle-$gradle_version-bin.zip" | ||
gradle_unzipped_package="gradle-$gradle_version" | ||
wget https://downloads.gradle.org/distributions/gradle-$gradle_version-bin.zip | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The team is using ubuntu 20.04 as base version. So can you rollback to 20.04 to avoid some side effect issue. The team will plan to support latest LTS version later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a mistake for me to switch to latest, but I also think it is a mistake for us to sit on 20.04 at this point. How long do you think before we upgrade to the current LTS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coty thanks for your reminding
https://wiki.ubuntu.com/Releases
Ubuntu 20.04 LTS - End of Standard Support: [April 2025]
We should upgrade to Ubuntu 22.04.4 LTS - End of Standard Support: [June 2027]
cc @anvantran @trinh-h