Update php-sdk to v2 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #2771: [php-sdk] Update to v2. |
ggeorgiadis
reviewed
Mar 23, 2023
0-sv
commented
Mar 27, 2023
ggeorgiadis
reviewed
Mar 28, 2023
ggeorgiadis
approved these changes
Mar 29, 2023
ahmadshabib
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we released api v2 we need to update our sdk.
It might be beneficial for us to generate the sdk since we have a proper swagger file. I attempted to do that and the results look good, I am able to query GetAvailability from
platformusing the generated sdk.Motivation and context
@ggeorgiadis, @gpopides and me agreed to meet to discuss the results and there are some pros and cons for taking this approach. Since we have only an internal consumer and we would like this to scale such that we can generate also a sdk with our desired output for other languages we are taking this approach where we generate the sdk. It means we lose control over the output but since it is convenient to generate we are accepting that.
How has this been tested?
make gento see the resultsplatformand seeing a successful connection.Screenshots (if appropriate)
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply: