Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context.CookieAllowReclaim): Fix the issue with the context.Cooki… #2136

Merged
merged 1 commit into from
May 11, 2023

Conversation

auxpd
Copy link
Contributor

@auxpd auxpd commented May 11, 2023

…eAllowReclaim method not working as expected when deleting cookies

When deleting cookies, if the cookie is the first element and there is
no semicolon before the string, it prevents the matching of this cookie.

Closes #2134

We'd love to see more contributions

Read how you can contribute to the project.

Please attach an issue link which your PR solves otherwise your work may be rejected.

…eAllowReclaim method not working as expected when deleting cookies

When deleting cookies, if the cookie is the first element and there
is
no semicolon before the string, it prevents the matching of this
cookie.

Closes kataras#2134
@auxpd auxpd requested a review from kataras as a code owner May 11, 2023 13:57
Copy link
Owner

@kataras kataras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, this looks better and cleaner than my solution, good job @auxpd. Approved.

@kataras kataras merged commit e05582b into kataras:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]context.CookieAllowReclaim method failed to properly delete the cookie.
2 participants