Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related to Issue #6 to properly load the vendorsList #13

Merged
merged 2 commits into from
Oct 23, 2021

Conversation

charles-tan
Copy link
Collaborator

Cleans up some of the linter errors and fixes the call to loadVendorsList(). I verified this works by printing the return from the GET call and it looks correct. Can't fix showVendors until we can successfully parse and store the consentString.

src/popup/popup.js Outdated Show resolved Hide resolved
@@ -223,6 +228,7 @@ function fetchVendorList() {
redirect: 'follow',
referrer: 'client',
});
console.log('fetchVendorList', req);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this console log?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were already logging it before

@charles-tan charles-tan merged commit bc50c24 into main Oct 23, 2021
@charles-tan charles-tan deleted the issue_6_fix_load_vendors_list branch October 23, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants